Code Review for 2

Prepared by:John Levon on 2020-Apr-28 02:57 -0700 PDT
Workspace:/export/home/gk/src/2 (at b310a6d7a6dc)
Compare against: /export/home/gk/src/2 (explicit revision cd8579f741f9)
Summary of changes: 446 lines changed: 396 ins; 27 del; 23 mod; 61869 unchg
Patch of changes: 2.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadm/zoneadm.c

OS-192 zone_create() warning on headnode
101 lines changed: 84 ins; 14 del; 3 mod; 5788 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/vplat.c

OS-192 zone_create() warning on headnode
8 lines changed: 6 ins; 0 del; 2 mod; 5418 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zoneadmd.c

OS-192 zone_create() warning on headnode
10 lines changed: 6 ins; 0 del; 4 mod; 2294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/zoneadmd.h

OS-192 zone_create() warning on headnode
2 lines changed: 1 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg.c

OS-192 zone_create() warning on headnode
6 lines changed: 6 ins; 0 del; 0 mod; 7623 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/libzonecfg.h

OS-192 zone_create() warning on headnode
3 lines changed: 3 ins; 0 del; 0 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/zone.h

OS-192 zone_create() warning on headnode
2 lines changed: 1 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

INTRO-118 enabling USDT probes in zones should be more scalable
1 line changed: 0 ins; 0 del; 1 mod; 745 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/sys/zone.c

OS-192 zone_create() warning on headnode
4 lines changed: 3 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/Makefile.com

OS-279 #pragma D option zone= does not work on installed, halted zones
1 line changed: 0 ins; 0 del; 1 mod; 275 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_impl.h

INTRO-118 enabling USDT probes in zones should be more scalable
1 line changed: 1 ins; 0 del; 0 mod; 690 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_options.c

OS-279 #pragma D option zone= does not work on installed, halted zones
OS-208 DTrace needs to use zone_did to match zone-limited enablings
INTRO-118 enabling USDT probes in zones should be more scalable
41 lines changed: 41 ins; 0 del; 0 mod; 1081 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_program.c

INTRO-118 enabling USDT probes in zones should be more scalable
19 lines changed: 19 ins; 0 del; 0 mod; 617 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_work.c

INTRO-118 enabling USDT probes in zones should be more scalable
15 lines changed: 2 ins; 12 del; 1 mod; 285 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/common/libzonecfg.c

/etc/zones/did.txt should be alternate-root aware
OS-192 zone_create() warning on headnode
168 lines changed: 168 ins; 0 del; 0 mod; 8281 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/common/mapfile-vers

OS-192 zone_create() warning on headnode
4 lines changed: 4 ins; 0 del; 0 mod; 246 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzonecfg/dtd/zonecfg.dtd.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

OS-192 zone_create() warning on headnode
2 lines changed: 2 ins; 0 del; 0 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/dtrace.c

OS-208 DTrace needs to use zone_did to match zone-limited enablings
INTRO-118 enabling USDT probes in zones should be more scalable
22 lines changed: 16 ins; 1 del; 5 mod; 17307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cred.c

OS-208 DTrace needs to use zone_did to match zone-limited enablings
8 lines changed: 8 ins; 0 del; 0 mod; 1480 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/zone.c

OS-208 DTrace needs to use zone_did to match zone-limited enablings
OS-192 zone_create() warning on headnode
22 lines changed: 19 ins; 0 del; 3 mod; 7382 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cred.h

OS-208 DTrace needs to use zone_did to match zone-limited enablings
1 line changed: 1 ins; 0 del; 0 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/zone.h

OS-208 DTrace needs to use zone_did to match zone-limited enablings
OS-192 zone_create() warning on headnode
5 lines changed: 5 ins; 0 del; 0 mod; 889 unchg

This code review page was prepared using /export/home/gk/src/2/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.