Code Review for illumos-gate

Prepared by:John Levon on 2019-Apr-09 16:34 -0700 PDT
Workspace:/export/home/gk/src/illumos-gate (explicit head at dbcc2de8dadf)
Compare against: previous revision (at a8cc26d68f69)
Summary of changes: 83 lines changed: 38 ins; 4 del; 41 mod; 4581 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/Makefile.uts

10686 Debug macros causes smatch issues
6 lines changed: 6 ins; 0 del; 0 mod; 654 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/srpt/srpt_impl.h

10686 Debug macros causes smatch issues
9 lines changed: 4 ins; 0 del; 5 mod; 524 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/pciex/pcieb.h

10686 Debug macros causes smatch issues
9 lines changed: 4 ins; 0 del; 5 mod; 196 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/eoib/eib_impl.h

10686 Debug macros causes smatch issues
8 lines changed: 4 ins; 0 del; 4 mod; 987 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/eoib/enx_impl.h

10686 Debug macros causes smatch issues
9 lines changed: 4 ins; 0 del; 5 mod; 527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/rds/rdsib_debug.h

10686 Debug macros causes smatch issues
10 lines changed: 4 ins; 2 del; 4 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/rdsv3/rdsv3_debug.h

10686 Debug macros causes smatch issues
8 lines changed: 4 ins; 0 del; 4 mod; 135 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/ibtl/impl/ibtl_util.h

10686 Debug macros causes smatch issues
10 lines changed: 4 ins; 2 del; 4 mod; 152 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/pcie_impl.h

10686 Debug macros causes smatch issues
9 lines changed: 4 ins; 0 del; 5 mod; 617 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/scsa2usb/scsa2usb.h

10686 Debug macros causes smatch issues
5 lines changed: 0 ins; 0 del; 5 mod; 669 unchg

This code review page was prepared using /export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.