Code Review for il_10366-3

Prepared by:Richard Lowe on 2019-Mar-01 17:10 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at 698fb2954f36)
Compare against: /builds/richlowe/illumos-git (explicit revision 97d03884249a)
Summary of changes: 20 lines changed: 10 ins; 6 del; 4 mod; 16495 unchg
Patch of changes: il_10366-3.patch
Printable review: il_10366-3.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/Makefile

10476 file(1) could be smatch clean
3 lines changed: 0 ins; 3 del; 0 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/elf_read.c

10476 file(1) could be smatch clean
1 line changed: 0 ins; 0 del; 1 mod; 593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/file.c

10476 file(1) could be smatch clean
2 lines changed: 1 ins; 0 del; 1 mod; 1904 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/magicutils.c

10476 file(1) could be smatch clean
3 lines changed: 0 ins; 2 del; 1 mod; 1139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/args.c

code review from Robert
5 lines changed: 5 ins; 0 del; 0 mod; 2251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/files.c

code review from Robert
2 lines changed: 1 ins; 0 del; 1 mod; 3737 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/sections.c

code review from Robert
1 line changed: 1 ins; 0 del; 0 mod; 3531 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/syms.c

code review from Robert
3 lines changed: 2 ins; 1 del; 0 mod; 3228 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.