Print this page
code review from Robert

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/sgs/libld/common/args.c
          +++ new/usr/src/cmd/sgs/libld/common/args.c
↓ open down ↓ 1540 lines elided ↑ open up ↑
1541 1541  
1542 1542                          /*
1543 1543                           * Process everything related to -z assert-deflib. This
1544 1544                           * must be done in pass 1 because it gets used in pass
1545 1545                           * 2.
1546 1546                           */
1547 1547                          } else if (strncmp(optarg, MSG_ORIG(MSG_ARG_ASSDEFLIB),
1548 1548                              MSG_ARG_ASSDEFLIB_SIZE) == 0) {
1549 1549                                  if (assdeflib_parse(ofl, optarg) != TRUE)
1550 1550                                          return (S_ERROR);
     1551 +
     1552 +                        /*
     1553 +                         * Process new-style output type specification, which
     1554 +                         * we'll use in pass 2 and throughout.
     1555 +                         */
1551 1556                          } else if (strncmp(optarg, MSG_ORIG(MSG_ARG_TYPE),
1552 1557                              MSG_ARG_TYPE_SIZE) == 0) {
1553 1558                                  char *p = optarg + MSG_ARG_TYPE_SIZE;
1554 1559                                  if (*p != '=') {
1555 1560                                          ld_eprintf(ofl, ERR_FATAL,
1556 1561                                              MSG_INTL(MSG_ARG_ILLEGAL),
1557 1562                                              MSG_ORIG(MSG_ARG_Z), optarg);
1558 1563                                          return (S_ERROR);
1559 1564                                  }
1560 1565  
↓ open down ↓ 691 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX