Print this page
code review from Robert

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/sgs/libld/common/files.c
          +++ new/usr/src/cmd/sgs/libld/common/files.c
↓ open down ↓ 3189 lines elided ↑ open up ↑
3190 3190                          _rej.rej_name = name;
3191 3191                          DBG_CALL(Dbg_file_rejected(ofl->ofl_lml, &_rej,
3192 3192                              ld_targ.t_m.m_mach));
3193 3193                          if (rej->rej_type == 0) {
3194 3194                                  *rej = _rej;
3195 3195                                  rej->rej_name = strdup(_rej.rej_name);
3196 3196                          }
3197 3197                          return (0);
3198 3198                  }
3199 3199  
3200      -                if (_gelf_getdynval(elf, DT_SUNW_KMOD) == 1) {
     3200 +                if (_gelf_getdynval(elf, DT_SUNW_KMOD) > 0) {
3201 3201                          _rej.rej_name = name;
3202 3202                          DBG_CALL(Dbg_file_rejected(ofl->ofl_lml, &_rej,
3203 3203                              ld_targ.t_m.m_mach));
3204 3204                          _rej.rej_type = SGS_REJ_KMOD;
3205 3205                          _rej.rej_str = elf_errmsg(-1);
     3206 +                        _rej.rej_name = name;
3206 3207  
3207 3208                          if (rej->rej_type == 0) {
3208 3209                                  *rej = _rej;
3209 3210                                  rej->rej_name = strdup(_rej.rej_name);
3210 3211                          }
3211 3212                          return (0);
3212 3213                  }
3213 3214  
3214 3215                  /*
3215 3216                   * Determine if we've already come across this file.
↓ open down ↓ 523 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX