Code Review for facl-gate

Prepared by:Peter Tribble on 2020-Feb-08 11:08 -0800 PST
Workspace:/export/home/ptribble/Illumos/facl-gate (at b98bd266ae4d)
Compare against: origin/master (/export/home/ptribble/Illumos-reference/illumos-gate at 0dfe541e1327)
Summary of changes: 199 lines changed: 35 ins; 97 del; 67 mod; 3846 unchg
Patch of changes: facl-gate.patch
Printable review: facl-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/getfacl/Makefile 

12288 getfacl and setfacl could stand improvement
8 lines changed: 2 ins; 5 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/getfacl/getfacl.c 

12288 getfacl and setfacl could stand improvement
9 lines changed: 1 ins; 6 del; 2 mod; 332 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/setfacl/Makefile 

12288 getfacl and setfacl could stand improvement
11 lines changed: 1 ins; 9 del; 1 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/setfacl/setfacl.c 

12288 getfacl and setfacl could stand improvement
31 lines changed: 13 ins; 14 del; 4 mod; 811 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/getfacl.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
45 lines changed: 9 ins; 17 del; 19 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/setfacl.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
29 lines changed: 8 ins; 11 del; 10 mod; 357 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3sec/acl_totext.3sec
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
11 lines changed: 0 ins; 10 del; 1 mod; 753 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3sec/aclcheck.3sec
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
12 lines changed: 0 ins; 9 del; 3 mod; 210 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3sec/acltotext.3sec
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
10 lines changed: 0 ins; 9 del; 1 mod; 228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/acl.5
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

12288 getfacl and setfacl could stand improvement
33 lines changed: 1 ins; 7 del; 25 mod; 807 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.