Code Review for illumos-gate

Prepared by:Mohamed A. Khalfella (illumos) on 2015-Dec-04 14:19 +0300 EAT
Workspace:/illumos-dev_ns01/illumos-gate (at 1358904dfe5c)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at b289d045e084)
Summary of changes: 1726 lines changed: 1318 ins; 260 del; 148 mod; 58031 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/netstat/Makefile

XXXX adding PID information to netstat output
1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/netstat/netstat.c

XXXX adding PID information to netstat output
727 lines changed: 626 ins; 4 del; 97 mod; 6354 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/cmd-inet/usr.bin/netstat/unix.c (deleted)

XXXX adding PID information to netstat output
243 lines changed: 0 ins; 243 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Kstat/Kstat.xs

XXXX adding PID information to netstat output
2 lines changed: 0 ins; 0 del; 2 mod; 1687 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

XXXX adding PID information to netstat output
1 line changed: 1 ins; 0 del; 0 mod; 2138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

XXXX adding PID information to netstat output
1 line changed: 1 ins; 0 del; 0 mod; 2177 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/doorfs/door_sys.c

XXXX adding PID information to netstat output
7 lines changed: 6 ins; 0 del; 1 mod; 3561 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/sockfs/sockcommon.c

XXXX adding PID information to netstat output
54 lines changed: 54 ins; 0 del; 0 mod; 666 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/sockfs/sockcommon.h

XXXX adding PID information to netstat output
3 lines changed: 3 ins; 0 del; 0 mod; 250 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/sockfs/sockcommon_sops.c

XXXX adding PID information to netstat output
43 lines changed: 42 ins; 0 del; 1 mod; 1956 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/sockfs/sockcommon_vnops.c

XXXX adding PID information to netstat output
19 lines changed: 19 ins; 0 del; 0 mod; 482 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/sockfs/socksubr.c

XXXX adding PID information to netstat output
98 lines changed: 52 ins; 12 del; 34 mod; 1903 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ipclassifier.c

XXXX adding PID information to netstat output
27 lines changed: 27 ins; 0 del; 0 mod; 2724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipclassifier.h

XXXX adding PID information to netstat output
1 line changed: 1 ins; 0 del; 0 mod; 737 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/mib2.h

XXXX adding PID information to netstat output
1 line changed: 1 ins; 0 del; 0 mod; 1794 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/sctp/sctp_snmp.c

XXXX adding PID information to netstat output
24 lines changed: 22 ins; 0 del; 2 mod; 967 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/snmpcom.c

XXXX adding PID information to netstat output
26 lines changed: 26 ins; 0 del; 0 mod; 322 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/snmpcom.h

XXXX adding PID information to netstat output
3 lines changed: 3 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/sockmods/socksctp.c

XXXX adding PID information to netstat output
26 lines changed: 26 ins; 0 del; 0 mod; 2232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_stats.c

XXXX adding PID information to netstat output
52 lines changed: 51 ins; 0 del; 1 mod; 1056 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/udp/udp_stats.c

XXXX adding PID information to netstat output
50 lines changed: 48 ins; 1 del; 1 mod; 587 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/fio.c

XXXX adding PID information to netstat output
16 lines changed: 15 ins; 0 del; 1 mod; 1827 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/fork.c

XXXX adding PID information to netstat output
1 line changed: 0 ins; 0 del; 1 mod; 1461 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/os/pidnode.c

XXXX adding PID information to netstat output
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/streamio.c

XXXX adding PID information to netstat output
56 lines changed: 56 ins; 0 del; 0 mod; 8637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/strsubr.c

XXXX adding PID information to netstat output
96 lines changed: 92 ins; 0 del; 4 mod; 8792 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

XXXX adding PID information to netstat output
1 line changed: 1 ins; 0 del; 0 mod; 1366 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fcntl.h

XXXX adding PID information to netstat output
3 lines changed: 3 ins; 0 del; 0 mod; 406 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/file.h

XXXX adding PID information to netstat output
1 line changed: 0 ins; 0 del; 1 mod; 248 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/pidnode.h

XXXX adding PID information to netstat output
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/socket_proto.h

XXXX adding PID information to netstat output
2 lines changed: 2 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/socketvar.h

XXXX adding PID information to netstat output
17 lines changed: 16 ins; 0 del; 1 mod; 1068 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/strsubr.h

XXXX adding PID information to netstat output
9 lines changed: 9 ins; 0 del; 0 mod; 1347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/syscall/fcntl.c

XXXX adding PID information to netstat output
22 lines changed: 22 ins; 0 del; 0 mod; 940 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.