Code Review for illumos5910-1

Prepared by:Gary Mills (mills) on 2015-Jul-24 12:28 -0500 CDT
Workspace:/dpool/export/home/mills/Downloads/code/illumos-gate (at 8978ed32c419)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 77eb9dd4fa1a)
Summary of changes: 364 lines changed: 229 ins; 82 del; 53 mod; 31352 unchg
Patch of changes: illumos5910-1.patch
Printable review: illumos5910-1.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/Makefile

5910 libnisdb won't build with modern GCC
33 lines changed: 29 ins; 2 del; 2 mod; 210 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_dictionary_c.x

5910 libnisdb won't build with modern GCC
4 lines changed: 3 ins; 0 del; 1 mod; 293 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_dictxdr.c

5910 libnisdb won't build with modern GCC
4 lines changed: 2 ins; 2 del; 0 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_entry_c.x

5910 libnisdb won't build with modern GCC
7 lines changed: 5 ins; 2 del; 0 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_index_c.x

5910 libnisdb won't build with modern GCC
5 lines changed: 5 ins; 0 del; 0 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_index_entry_c.c

5910 libnisdb won't build with modern GCC
8 lines changed: 6 ins; 2 del; 0 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_mindex3.cc

5910 libnisdb won't build with modern GCC
8 lines changed: 3 ins; 1 del; 4 mod; 932 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_mindex_c.x

5910 libnisdb won't build with modern GCC
9 lines changed: 6 ins; 3 del; 0 mod; 375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_scheme_c.x

5910 libnisdb won't build with modern GCC
4 lines changed: 3 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_table.cc

5910 libnisdb won't build with modern GCC
3 lines changed: 2 ins; 0 del; 1 mod; 1151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/db_vers_c.x

5910 libnisdb won't build with modern GCC
4 lines changed: 3 ins; 0 del; 1 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_attr.c

5910 libnisdb won't build with modern GCC
5 lines changed: 1 ins; 2 del; 2 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_map.c

5910 libnisdb won't build with modern GCC
5 lines changed: 1 ins; 3 del; 1 mod; 1822 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_nisdbquery.c

5910 libnisdb won't build with modern GCC
6 lines changed: 2 ins; 2 del; 2 mod; 1223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_op.c

5910 libnisdb won't build with modern GCC
5 lines changed: 1 ins; 3 del; 1 mod; 2738 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_ruleval.c

5910 libnisdb won't build with modern GCC
10 lines changed: 1 ins; 7 del; 2 mod; 1073 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_val.c

5910 libnisdb won't build with modern GCC
2 lines changed: 1 ins; 0 del; 1 mod; 2480 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_xdr.c

5910 libnisdb won't build with modern GCC
4 lines changed: 1 ins; 2 del; 1 mod; 762 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/ldap_xdr.h

5910 libnisdb won't build with modern GCC
7 lines changed: 5 ins; 2 del; 0 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nis_db.cc

5910 libnisdb won't build with modern GCC
3 lines changed: 2 ins; 0 del; 1 mod; 1933 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_conf.c

5910 libnisdb won't build with modern GCC
11 lines changed: 6 ins; 4 del; 1 mod; 1570 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_map.c

5910 libnisdb won't build with modern GCC
16 lines changed: 3 ins; 6 del; 7 mod; 2711 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_util.c

5910 libnisdb won't build with modern GCC
4 lines changed: 2 ins; 2 del; 0 mod; 2687 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_util.h

5910 libnisdb won't build with modern GCC
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_yp_util.c

5910 libnisdb won't build with modern GCC
11 lines changed: 2 ins; 4 del; 5 mod; 1330 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libnisdb/nis_parse_ldap_yp_util.h

5910 libnisdb won't build with modern GCC
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/nisdb_rw.c

5910 libnisdb won't build with modern GCC
22 lines changed: 2 ins; 7 del; 13 mod; 722 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libnisdb/xdr_nullptr.h

5910 libnisdb won't build with modern GCC
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/dit_access_utils.c

5910 libnisdb won't build with modern GCC
8 lines changed: 2 ins; 2 del; 4 mod; 1995 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/lock_update.c

5910 libnisdb won't build with modern GCC
5 lines changed: 1 ins; 2 del; 2 mod; 397 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/map_conv.c

5910 libnisdb won't build with modern GCC
4 lines changed: 1 ins; 3 del; 0 mod; 410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/shim.c

5910 libnisdb won't build with modern GCC
4 lines changed: 2 ins; 2 del; 0 mod; 670 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/shim_ancil.c

5910 libnisdb won't build with modern GCC
7 lines changed: 1 ins; 6 del; 0 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/shim_changepasswd.c

5910 libnisdb won't build with modern GCC
10 lines changed: 6 ins; 4 del; 0 mod; 1339 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/shim_lockmap.c

5910 libnisdb won't build with modern GCC
4 lines changed: 2 ins; 2 del; 0 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/ttl_utils.c

5910 libnisdb won't build with modern GCC
4 lines changed: 1 ins; 3 del; 0 mod; 332 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnisdb/yptol/update.c

5910 libnisdb won't build with modern GCC
5 lines changed: 3 ins; 2 del; 0 mod; 376 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.