Code Review for illumos2989-6

Prepared by:Gary Mills (mills) on 2013-Sep-04 20:46 -0500 CDT
Workspace:/home/mills/Downloads/code/illumos-gate (at f81ee4aae963)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 33915f34e743)
Summary of changes: 1323 lines changed: 1005 ins; 78 del; 240 mod; 30783 unchg
Patch of changes: illumos2989-6.patch
Printable review: illumos2989-6.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/init/init.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
96 lines changed: 15 ins; 2 del; 79 mod; 4507 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/last/last.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
30 lines changed: 7 ins; 4 del; 19 mod; 508 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/newtask/newtask.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
5 lines changed: 2 ins; 2 del; 1 mod; 800 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/inc/users.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 3 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/lib/vlogin.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
37 lines changed: 29 ins; 3 del; 5 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
5 lines changed: 4 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/messages.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
5 lines changed: 3 ins; 2 del; 0 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/messages.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 5 ins; 2 del; 0 mod; 150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/useradd.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 7 ins; 0 del; 0 mod; 755 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/oamuser/user/useradd.dfl

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/usermod.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
8 lines changed: 8 ins; 0 del; 0 mod; 675 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prstat.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
35 lines changed: 19 ins; 0 del; 16 mod; 1639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prstat.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 3 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prtable.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
20 lines changed: 17 ins; 0 del; 3 mod; 313 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prtable.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prutil.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
30 lines changed: 21 ins; 0 del; 9 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prutil.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
4 lines changed: 2 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ps/ps.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
169 lines changed: 134 ins; 1 del; 34 mod; 2360 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pwck/pwck.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
9 lines changed: 3 ins; 2 del; 4 mod; 230 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/w/w.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
19 lines changed: 7 ins; 8 del; 4 mod; 741 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/wall/wall.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
23 lines changed: 4 ins; 11 del; 8 mod; 486 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/who/who.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
37 lines changed: 12 ins; 10 del; 15 mod; 842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/whodo/whodo.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
28 lines changed: 10 ins; 9 del; 9 mod; 825 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/limits.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
13 lines changed: 11 ins; 2 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/stdlib.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
28 lines changed: 28 ins; 0 del; 0 mod; 362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/unistd.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
108 lines changed: 97 ins; 10 del; 1 mod; 1023 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
2 lines changed: 2 ins; 0 del; 0 mod; 701 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/Makefile.com

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/amd64/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/common/getloginx.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/common/mapfile-vers

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/i386/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/sparc/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/getloginx/sparcv9/Makefile

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/getlogin.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
109 lines changed: 85 ins; 10 del; 14 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/sysconf.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 545 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/llib-lc

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
10 lines changed: 10 ins; 0 del; 0 mod; 1792 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
5 lines changed: 5 ins; 0 del; 0 mod; 3140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/ps.1

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
20 lines changed: 16 ins; 0 del; 4 mod; 1315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/prstat.1m

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
24 lines changed: 21 ins; 0 del; 3 mod; 864 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/useradd.1m

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
10 lines changed: 9 ins; 0 del; 1 mod; 547 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/getlogin.3c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
43 lines changed: 41 ins; 0 del; 2 mod; 190 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/sysconf.3c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 1 ins; 0 del; 2 mod; 497 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/passwd.4

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 1 ins; 0 del; 2 mod; 347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
2 lines changed: 2 ins; 0 del; 0 mod; 1897 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.mf

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 3 ins; 0 del; 0 mod; 1280 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.