Code Review for illumos-gate

Prepared by:Joshua M. Clulow (leftwing) on 2012-Jun-30 22:01 +1000 EST
Workspace:/ws/illumos-gate (at 78b810cc9633)
Compare against: gate/master (git://github.com/illumos/illumos-gate.git at 7bc878958fba)
Summary of changes: 992 lines changed: 806 ins; 147 del; 39 mod; 8746 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Targetdirs 

2947 split up and ship pam.d/*, adjust Makefiles
1 line changed: 1 ins; 0 del; 0 mod; 1926 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

2947 add pamconv to upgrade pam.conf at boot
1 line changed: 1 ins; 0 del; 0 mod; 868 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/pamconv/Makefile 

2947 add pamconv to upgrade pam.conf at boot
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/pamconv/pam-upgrade.sh 

2947 add pamconv to upgrade pam.conf at boot
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/pamconv/pam-upgrade.xml 

2947 add pamconv to upgrade pam.conf at boot
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/pamconv/pamconv.c 

2947 add pamconv to upgrade pam.conf at boot
393 lines changed: 393 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpam/Makefile 

2947 split up and ship pam.d/*, adjust Makefiles
15 lines changed: 14 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpam/pam.conf 

2947 split up and ship pam.d/*, adjust Makefiles
133 lines changed: 0 ins; 130 del; 3 mod; 2 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/cron 

2947 split up and ship pam.d/*, adjust Makefiles
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/cups 

2947 split up and ship pam.d/*, adjust Makefiles
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/gdm-autologin 

2947 split up and ship pam.d/*, adjust Makefiles
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/krlogin 

2947 split up and ship pam.d/*, adjust Makefiles
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/krsh 

2947 split up and ship pam.d/*, adjust Makefiles
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/ktelnet 

2947 split up and ship pam.d/*, adjust Makefiles
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/login 

2947 split up and ship pam.d/*, adjust Makefiles
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/other 

2947 split up and ship pam.d/*, adjust Makefiles
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/passwd 

2947 split up and ship pam.d/*, adjust Makefiles
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/ppp 

2947 split up and ship pam.d/*, adjust Makefiles
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/rlogin 

2947 split up and ship pam.d/*, adjust Makefiles
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libpam/pam.d/rsh 

2947 split up and ship pam.d/*, adjust Makefiles
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpam/pam_framework.c 

2947 initial /etc/pam.d cut
137 lines changed: 93 ins; 17 del; 27 mod; 2840 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpam/pam_impl.h 

2947 initial /etc/pam.d cut
3 lines changed: 3 ins; 0 del; 0 mod; 254 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/Makefile 

2947 split up and ship pam.d/*, adjust Makefiles
3 lines changed: 3 ins; 0 del; 0 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/pam.conf.4 

2947 prelim manpage changes, packaging manifests
32 lines changed: 24 ins; 0 del; 8 mod; 461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.man4.inc 

2947 prelim manpage changes, packaging manifests
1 line changed: 1 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf 

2947 prelim manpage changes, packaging manifests
16 lines changed: 16 ins; 0 del; 0 mod; 1905 unchg

This code review page was prepared using usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.