Code Review for all

Prepared by:Gordon Ross (gwr) on 2018-Mar-18 01:13 -0400 EDT
Workspace:/tank/ws/smbcl-rpc (at 1cf913d7b19e)
Compare against: /tank/ws/smbcl-rpc (explicit revision 5f4fc069910e)
Summary of changes: 4238 lines changed: 2545 ins; 1465 del; 228 mod; 33700 unchg
Patch of changes: all.patch
Printable review: all.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

1575 untangle libmlrpc ... (packaging)
19 lines changed: 16 ins; 2 del; 1 mod; 999 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

1575 untangle libmlrpc ... (libmlrpc)
1 line changed: 1 ins; 0 del; 0 mod; 1184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/Makefile

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
21 lines changed: 13 ins; 4 del; 4 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/common.h

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
11 lines changed: 9 ins; 0 del; 2 mod; 67 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/info.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/shares_rap.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/shares_rpc.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/smbutil.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
4 lines changed: 4 ins; 0 del; 0 mod; 207 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1.ndl

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1_clnt.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1_clnt.h

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/view.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
68 lines changed: 16 ins; 26 del; 26 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/smbsrv/smb_door_legacy.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/smbsrv/smb_token_xdr.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 3 ins; 0 del; 1 mod; 722 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/Makefile

1575 untangle libmlrpc ... (libmlrpc)
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/Makefile.com

1575 untangle libmlrpc ... (libmlrpc)
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/amd64/Makefile (renamed and modified from usr/src/lib/smbsrv/libmlrpc/amd64/Makefile)

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 0 ins; 4 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/libmlrpc.h (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/libmlrpc.h)

1575 untangle libmlrpc ... (libmlrpc)
48 lines changed: 36 ins; 9 del; 3 mod; 533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/llib-lmlrpc (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/llib-lmlrpc)

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 2 ins; 2 del; 1 mod; 28 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/mapfile-vers

1575 untangle libmlrpc ... (libmlrpc)
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/mlrpc_clh.c

1575 untangle libmlrpc ... (libmlrpc)
578 lines changed: 578 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr.h (renamed and modified from usr/src/uts/common/smbsrv/ndr.h)

1575 untangle libmlrpc ... (libmlrpc)
14 lines changed: 4 ins; 9 del; 1 mod; 457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_client.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_client.c)

1575 untangle libmlrpc ... (libmlrpc)
14 lines changed: 2 ins; 10 del; 2 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_heap.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_heap.c)

1575 untangle libmlrpc ... (libmlrpc)
72 lines changed: 41 ins; 20 del; 11 mod; 266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_marshal.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_marshal.c)

1575 untangle libmlrpc ... (libmlrpc)
3 lines changed: 1 ins; 1 del; 1 mod; 646 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_ops.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_ops.c)

1575 untangle libmlrpc ... (libmlrpc)
2 lines changed: 0 ins; 1 del; 1 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_process.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_process.c)

1575 untangle libmlrpc ... (libmlrpc)
170 lines changed: 52 ins; 78 del; 40 mod; 1929 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_server.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_server.c)

1575 untangle libmlrpc ... (libmlrpc)
39 lines changed: 0 ins; 38 del; 1 mod; 799 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_svc.c (renamed and modified from usr/src/lib/smbsrv/libmlrpc/common/ndr_svc.c)

1575 untangle libmlrpc ... (libmlrpc)
2 lines changed: 0 ins; 1 del; 1 mod; 474 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/ndr_wchar.c

1575 untangle libmlrpc ... (libmlrpc)
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/ndr_wchar.h

1575 untangle libmlrpc ... (libmlrpc)
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndrtypes.ndl (renamed and modified from usr/src/uts/common/smbsrv/ndl/ndrtypes.ndl)

1575 untangle libmlrpc ... (libmlrpc)
39 lines changed: 21 ins; 14 del; 4 mod; 152 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/rpcpdu.ndl (renamed and modified from usr/src/uts/common/smbsrv/ndl/rpcpdu.ndl)

1575 untangle libmlrpc ... (libmlrpc)
1 line changed: 1 ins; 0 del; 0 mod; 665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/i386/Makefile (renamed and modified from usr/src/lib/smbsrv/libmlrpc/i386/Makefile)

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 0 ins; 4 del; 0 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/sparc/Makefile (renamed and modified from usr/src/lib/smbsrv/libmlrpc/sparc/Makefile)

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 0 ins; 4 del; 0 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/sparcv9/Makefile (renamed and modified from usr/src/lib/smbsrv/libmlrpc/sparcv9/Makefile)

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 0 ins; 4 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/Makefile.com

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 137 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsmbfs/netsmb/smb_netshareenum.h (deleted)

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
18 lines changed: 0 ins; 18 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/smb/llib-lsmbfs

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/smb/mapfile-vers

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 169 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsmbfs/smb/netshareenum.c (deleted)

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
378 lines changed: 0 ins; 378 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/Makefile

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 0 ins; 2 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/Makefile.targ

1575 untangle libmlrpc ... (smbsrv)
5 lines changed: 3 ins; 0 del; 2 mod; 40 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/smbsrv/libmlrpc/Makefile (deleted)

1575 untangle libmlrpc ... (move some files)
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/smbsrv/libmlrpc/Makefile.com (deleted)

1575 untangle libmlrpc ... (move some files)
56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/smbsrv/libmlrpc/common/mapfile-vers (deleted)

1575 untangle libmlrpc ... (move some files)
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/dssetup_clnt.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/dssetup_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/eventlog_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 578 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/libmlsvc.h

1575 untangle libmlrpc ... (smbsrv)
1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
53 lines changed: 15 ins; 36 del; 2 mod; 261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/lsar_clnt.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
33 lines changed: 3 ins; 17 del; 13 mod; 1318 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/lsar_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc.h

1575 untangle libmlrpc ... pre1:
 Move srvsvc_timecheck where it belongs
3 lines changed: 1 ins; 1 del; 1 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_client.c

1575 untangle libmlrpc ... (smbsrv)
1575 untangle libmlrpc ... (libmlrpc)
1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
1575 untangle libmlrpc ... pre1:
 Move srvsvc_timecheck where it belongs
500 lines changed: 19 ins; 447 del; 34 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_init.c

1575 untangle libmlrpc ... pre1:
 Move srvsvc_timecheck where it belongs
1 line changed: 0 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_util.c

1575 untangle libmlrpc ... (smbsrv)
40 lines changed: 40 ins; 0 del; 0 mod; 427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/msgsvc_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/netr_auth.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
7 lines changed: 4 ins; 1 del; 2 mod; 584 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/netr_logon.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 837 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/samr_clnt.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1023 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/samr_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1966 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/spoolss_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/srvsvc_clnt.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
1575 untangle libmlrpc ... pre1:
 Move srvsvc_timecheck where it belongs
96 lines changed: 10 ins; 64 del; 22 mod; 496 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/libsmb.h

1575 untangle libmlrpc ... (smbsrv)
7 lines changed: 4 ins; 3 del; 0 mod; 990 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_doorclnt.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 508 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-file-system-smb.mf

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1575 untangle libmlrpc ... (packaging)
5 lines changed: 0 ins; 5 del; 0 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-file-system-smb.mf

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 1 ins; 0 del; 0 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ndrgen/ndrgen.sh

1575 untangle libmlrpc ... (libmlrpc)
107 lines changed: 35 ins; 53 del; 19 mod; 64 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/quick/make-smbclnt

1575 untangle libmlrpc ... (libmlrpc)
303 lines changed: 303 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/quick/make-smbsrv

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smb/Makefile

1575 untangle libmlrpc ... (libmlrpc)
3 lines changed: 2 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smb/wintypes.h (renamed and modified from usr/src/uts/common/smbsrv/wintypes.h)

1575 untangle libmlrpc ... (libmlrpc)
32 lines changed: 11 ins; 16 del; 5 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/Makefile

1575 untangle libmlrpc ... (smbsrv)
5 lines changed: 0 ins; 4 del; 1 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/dssetup.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/eventlog.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/llsrpc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/lsarpc.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 0 del; 1 mod; 1036 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/msgsvc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/netdfs.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 519 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/netlogon.ndl

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/samrpc.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 0 ins; 0 del; 2 mod; 1457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/spoolss.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 0 del; 1 mod; 832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/srvsvc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 1705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/svcctl.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 603 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/winreg.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 477 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/netrauth.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_door.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_privilege.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_share.h

1575 untangle libmlrpc ... (smbsrv)
4 lines changed: 2 ins; 2 del; 0 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_sid.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_xdr.h

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 0 ins; 1 del; 1 mod; 381 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.