Code Review for 05

Prepared by:Gordon Ross (gwr) on 2018-Mar-18 01:13 -0400 EDT
Workspace:/tank/ws/smbcl-rpc (explicit head at 756952dfca6c)
Compare against: previous revision (at 761c07a51f21)
Summary of changes: 282 lines changed: 113 ins; 107 del; 62 mod; 20001 unchg
Patch of changes: 05.patch
Printable review: 05.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/smbsrv/smb_door_legacy.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/smbsrv/smb_token_xdr.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/Makefile

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 0 ins; 2 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/Makefile.targ

1575 untangle libmlrpc ... (smbsrv)
5 lines changed: 3 ins; 0 del; 2 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/dssetup_clnt.c

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/dssetup_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/eventlog_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 578 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/libmlsvc.h

1575 untangle libmlrpc ... (smbsrv)
35 lines changed: 15 ins; 18 del; 2 mod; 261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/lsar_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_client.c

1575 untangle libmlrpc ... (smbsrv)
121 lines changed: 19 ins; 68 del; 34 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_util.c

1575 untangle libmlrpc ... (smbsrv)
40 lines changed: 40 ins; 0 del; 0 mod; 427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/msgsvc_svc.c

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 1 del; 0 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/netr_logon.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 837 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/samr_clnt.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1023 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/samr_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1966 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/spoolss_svc.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 1223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/libsmb.h

1575 untangle libmlrpc ... (smbsrv)
7 lines changed: 4 ins; 3 del; 0 mod; 990 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_doorclnt.c

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 1 del; 0 mod; 508 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/quick/make-smbsrv

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/Makefile

1575 untangle libmlrpc ... (smbsrv)
5 lines changed: 0 ins; 4 del; 1 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/dssetup.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/eventlog.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/llsrpc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/lsarpc.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 0 del; 1 mod; 1036 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/msgsvc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/netdfs.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 519 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/netlogon.ndl

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/samrpc.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 0 ins; 0 del; 2 mod; 1457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/spoolss.ndl

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 1 ins; 0 del; 1 mod; 832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/srvsvc.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 1705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/svcctl.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 603 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/ndl/winreg.ndl

1575 untangle libmlrpc ... (smbsrv)
3 lines changed: 2 ins; 0 del; 1 mod; 477 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/netrauth.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_door.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_privilege.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_share.h

1575 untangle libmlrpc ... (smbsrv)
4 lines changed: 2 ins; 2 del; 0 mod; 283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_sid.h

1575 untangle libmlrpc ... (smbsrv)
1 line changed: 0 ins; 0 del; 1 mod; 304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_xdr.h

1575 untangle libmlrpc ... (smbsrv)
2 lines changed: 0 ins; 1 del; 1 mod; 381 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.