Code Review for 04

Prepared by:Gordon Ross (gwr) on 2018-Mar-18 01:13 -0400 EDT
Workspace:/tank/ws/smbcl-rpc (explicit head at 761c07a51f21)
Compare against: previous revision (at f74d1a1d9137)
Summary of changes: 2094 lines changed: 1388 ins; 574 del; 132 mod; 9416 unchg
Patch of changes: 04.patch
Printable review: 04.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

1575 untangle libmlrpc ... (libmlrpc)
1 line changed: 1 ins; 0 del; 0 mod; 1184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 3 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/Makefile

1575 untangle libmlrpc ... (libmlrpc)
38 lines changed: 35 ins; 0 del; 3 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/Makefile.com

1575 untangle libmlrpc ... (libmlrpc)
32 lines changed: 22 ins; 3 del; 7 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/amd64/Makefile

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 0 ins; 4 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/libmlrpc.h

1575 untangle libmlrpc ... (libmlrpc)
48 lines changed: 36 ins; 9 del; 3 mod; 533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/llib-lmlrpc

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 2 ins; 2 del; 1 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/mapfile-vers

1575 untangle libmlrpc ... (libmlrpc)
61 lines changed: 30 ins; 3 del; 28 mod; 57 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/mlrpc_clh.c

1575 untangle libmlrpc ... (libmlrpc)
578 lines changed: 578 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr.h

1575 untangle libmlrpc ... (libmlrpc)
14 lines changed: 4 ins; 9 del; 1 mod; 457 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_client.c

1575 untangle libmlrpc ... (libmlrpc)
14 lines changed: 2 ins; 10 del; 2 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_heap.c

1575 untangle libmlrpc ... (libmlrpc)
72 lines changed: 41 ins; 20 del; 11 mod; 266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_marshal.c

1575 untangle libmlrpc ... (libmlrpc)
3 lines changed: 1 ins; 1 del; 1 mod; 646 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_ops.c

1575 untangle libmlrpc ... (libmlrpc)
2 lines changed: 0 ins; 1 del; 1 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_process.c

1575 untangle libmlrpc ... (libmlrpc)
170 lines changed: 52 ins; 78 del; 40 mod; 1929 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_server.c

1575 untangle libmlrpc ... (libmlrpc)
39 lines changed: 0 ins; 38 del; 1 mod; 799 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndr_svc.c

1575 untangle libmlrpc ... (libmlrpc)
2 lines changed: 0 ins; 1 del; 1 mod; 474 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/ndr_wchar.c

1575 untangle libmlrpc ... (libmlrpc)
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmlrpc/common/ndr_wchar.h

1575 untangle libmlrpc ... (libmlrpc)
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/ndrtypes.ndl

1575 untangle libmlrpc ... (libmlrpc)
39 lines changed: 21 ins; 14 del; 4 mod; 152 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/common/rpcpdu.ndl

1575 untangle libmlrpc ... (libmlrpc)
1 line changed: 1 ins; 0 del; 0 mod; 665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/i386/Makefile

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 0 ins; 4 del; 0 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/sparc/Makefile

1575 untangle libmlrpc ... (libmlrpc)
4 lines changed: 0 ins; 4 del; 0 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmlrpc/sparcv9/Makefile

1575 untangle libmlrpc ... (libmlrpc)
5 lines changed: 0 ins; 4 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_client.c

1575 untangle libmlrpc ... (libmlrpc)
300 lines changed: 0 ins; 300 del; 0 mod; 269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ndrgen/ndrgen.sh

1575 untangle libmlrpc ... (libmlrpc)
107 lines changed: 35 ins; 53 del; 19 mod; 64 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/quick/make-smbclnt

1575 untangle libmlrpc ... (libmlrpc)
303 lines changed: 303 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smb/Makefile

1575 untangle libmlrpc ... (libmlrpc)
3 lines changed: 2 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smb/wintypes.h

1575 untangle libmlrpc ... (libmlrpc)
32 lines changed: 11 ins; 16 del; 5 mod; 56 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.