Code Review for 02

Prepared by:Gordon Ross (gwr) on 2018-Mar-18 01:12 -0400 EDT
Workspace:/tank/ws/smbcl-rpc (explicit head at 5525fb8fd7f0)
Compare against: previous revision (at 6213f4e91ccf)
Summary of changes: 190 lines changed: 7 ins; 168 del; 15 mod; 3280 unchg
Patch of changes: 02.patch
Printable review: 02.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/libmlsvc.h

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
18 lines changed: 0 ins; 18 del; 0 mod; 281 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/lsar_clnt.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
33 lines changed: 3 ins; 17 del; 13 mod; 1318 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/mlsvc_client.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
34 lines changed: 0 ins; 34 del; 0 mod; 569 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/netr_auth.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
7 lines changed: 4 ins; 1 del; 2 mod; 584 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/common/srvsvc_clnt.c

1575 untangle libmlrpc ... pre2:
 Get rid of ndr_rpc_server_{info,os}
98 lines changed: 0 ins; 98 del; 0 mod; 528 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.