Code Review for tcp-static

Prepared by:david (david) on 2012-Aug-08 12:51 +0000 UTC
Workspace:/home/david/ws/tcp-static (at 252369ebd8c6)
Compare against: origin/master (/home/david/ws/illumos-gate/ at 12f7d0bd7deb)
Summary of changes: 32 lines changed: 18 ins; 5 del; 9 mod; 4249 unchg
Patch of changes: tcp-static.patch
Printable review: tcp-static.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_opt_data.c

3065 some functions in the tcp module can be static
3 lines changed: 2 ins; 0 del; 1 mod; 1088 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_socket.c

3065 some functions in the tcp module can be static
19 lines changed: 15 ins; 0 del; 4 mod; 1168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_stats.c

3065 some functions in the tcp module can be static
4 lines changed: 1 ins; 0 del; 3 mod; 1038 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_impl.h

3065 some functions in the tcp module can be static
5 lines changed: 0 ins; 5 del; 0 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_stats.h

3065 some functions in the tcp module can be static
1 line changed: 0 ins; 0 del; 1 mod; 250 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.