Code Review for illumos2989-2

Prepared by:Gary Mills (mills) on 2013-Apr-03 09:33 -0500 CDT
Workspace:/home/mills/Downloads/code/illumos-gate (at 1e06ff1f248c)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at b3a6f80422cf)
Summary of changes: 444 lines changed: 182 ins; 65 del; 197 mod; 23106 unchg
Patch of changes: illumos2989-2.patch
Printable review: illumos2989-2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/grpck/grpck.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
17 lines changed: 8 ins; 2 del; 7 mod; 407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/init/init.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
96 lines changed: 15 ins; 2 del; 79 mod; 4507 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/last/last.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
30 lines changed: 7 ins; 4 del; 19 mod; 508 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/newtask/newtask.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 3 ins; 2 del; 2 mod; 799 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/inc/users.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 3 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/lib/vlogin.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
11 lines changed: 2 ins; 6 del; 3 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/messages.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
5 lines changed: 3 ins; 2 del; 0 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/messages.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 5 ins; 2 del; 0 mod; 150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/useradd.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 7 ins; 0 del; 0 mod; 755 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/usermod.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
8 lines changed: 8 ins; 0 del; 0 mod; 675 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prstat.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
32 lines changed: 16 ins; 0 del; 16 mod; 1639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prtable.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
11 lines changed: 9 ins; 0 del; 2 mod; 314 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prtable.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prutil.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
25 lines changed: 17 ins; 0 del; 8 mod; 324 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/prstat/prutil.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
4 lines changed: 2 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ps/ps.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
4 lines changed: 3 ins; 0 del; 1 mod; 2394 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pwck/pwck.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
9 lines changed: 3 ins; 2 del; 4 mod; 230 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/w/w.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
19 lines changed: 7 ins; 8 del; 4 mod; 741 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/wall/wall.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
24 lines changed: 5 ins; 11 del; 8 mod; 486 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/who/who.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
37 lines changed: 12 ins; 10 del; 15 mod; 842 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/whodo/whodo.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
28 lines changed: 10 ins; 9 del; 9 mod; 825 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zlogin/zlogin.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
4 lines changed: 3 ins; 0 del; 1 mod; 2227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/limits.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 5 ins; 2 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/nss_dbdefs.h

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 844 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbsm/common/audit_ftpd.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
7 lines changed: 2 ins; 0 del; 5 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/getlogin.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
18 lines changed: 9 ins; 3 del; 6 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/sysconf.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 545 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/nsswitch/ldap/common/getnetgrent.c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
3 lines changed: 2 ins; 0 del; 1 mod; 1031 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/prstat.1m

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
8 lines changed: 8 ins; 0 del; 0 mod; 867 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/sysconf.3c

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
2 lines changed: 1 ins; 0 del; 1 mod; 498 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/passwd.4

2989 Eliminate use of LOGNAME_MAX in ON
1166 useradd have warning with name more 8 chars
2 lines changed: 1 ins; 0 del; 1 mod; 348 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.