| Prepared by: | Gordon Ross (gwr) on 2017-Mar-31 14:29 -0400 EDT |
|---|---|
| Workspace: | /tank/ws/smbsrv-dtprov1 (at 914dfb7513b4) |
| Compare against: | 6b927facfc1e (at 6b927facfc1e) |
| Summary of changes: | 833 lines changed: 752 ins; 40 del; 41 mod; 11902 unchg |
| Patch of changes: | smbsrv-dtprov1.patch |
| Printable review: | smbsrv-dtprov1.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/smbsrv/dtrace/Makefile
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid2 lines changed: 0 ins; 0 del; 2 mod; 50 unchg
------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/smbsrv/dtrace/smb-trace.d
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid166 lines changed: 166 ins; 0 del; 0 mod; 0 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/Makefile.com
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid1 line changed: 1 ins; 0 del; 0 mod; 270 unchg
------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdtrace/common/smb.d
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-dtrace.mf
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid1 line changed: 1 ins; 0 del; 0 mod; 667 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-file-system-smb.mf
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid1 line changed: 1 ins; 0 del; 0 mod; 120 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/sdt_subr.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid338 lines changed: 338 ins; 0 del; 0 mod; 1206 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_create.c
Build provider 3rd arg from smb_request_t hacking...6 lines changed: 0 ins; 3 del; 3 mod; 209 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_delete.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid1 line changed: 0 ins; 0 del; 1 mod; 613 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_directory.c
Build provider 3rd arg from smb_request_t hacking...6 lines changed: 0 ins; 3 del; 3 mod; 448 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_dispatch.c
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid6 lines changed: 2 ins; 1 del; 3 mod; 1357 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_negotiate.c
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid4 lines changed: 0 ins; 2 del; 2 mod; 644 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_nt_create_andx.c
Build provider 3rd arg from smb_request_t hacking...2 lines changed: 0 ins; 1 del; 1 mod; 399 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_nt_transact_create.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid5 lines changed: 1 ins; 2 del; 2 mod; 289 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_nt_transact_notify_change.c
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid2 lines changed: 2 ins; 0 del; 0 mod; 240 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_open_andx.c
Build provider 3rd arg from smb_request_t hacking...4 lines changed: 0 ins; 2 del; 2 mod; 596 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_print.c
Build provider 3rd arg from smb_request_t hacking...2 lines changed: 0 ins; 1 del; 1 mod; 319 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_query_fileinfo.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid2 lines changed: 0 ins; 1 del; 1 mod; 1001 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_read.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid67 lines changed: 55 ins; 6 del; 6 mod; 452 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_rename.c
Build provider 3rd arg from smb_request_t hacking...4 lines changed: 0 ins; 2 del; 2 mod; 230 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_session_setup_andx.c
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid4 lines changed: 0 ins; 2 del; 2 mod; 342 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_tree_connect.c
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid4 lines changed: 0 ins; 2 del; 2 mod; 452 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_write.c
Build provider 3rd arg from smb_request_t hacking... NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid76 lines changed: 60 ins; 8 del; 8 mod; 568 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/smbsrv/smb_kproto.h
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid4 lines changed: 0 ins; 4 del; 0 mod; 991 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sdt.h
NEX-1643 dtrace provider for smbsrv Also illumos 1841: DTrace smb provider was mis-implemented, doesn't exist. Add back handlers for read/write raw, so that legacy dtrace consumers can find the probes. Kill extra arg in smb_negotiate Fix missing "done" probe with smb_notify Add example consumer: smb-trace.d fix soi_pid6 lines changed: 6 ins; 0 del; 0 mod; 439 unchg
This code review page was prepared using /tank/ws/smbsrv-dtprov1/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.