Code Review for illumos-dccp

Prepared by:david (david) on 2012-Jun-13 12:06 +0000 UTC
Workspace:/home/david/illumos-dccp (at 25c69270fdac)
Compare against: 7d7551bcfe (at 7d7551bcfe5d)
Summary of changes: 4326 lines changed: 4307 ins; 6 del; 13 mod; 75685 unchg
Patch of changes: illumos-dccp.patch
Printable review: illumos-dccp.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.c

%B
2 lines changed: 0 ins; 0 del; 2 mod; 2219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/ip/ip.c

%B
12 lines changed: 11 ins; 0 del; 1 mod; 3629 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_prop.c

%B
32 lines changed: 30 ins; 0 del; 2 mod; 1938 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.mf

%B
14 lines changed: 14 ins; 0 del; 0 mod; 911 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

%B
8 lines changed: 7 ins; 0 del; 1 mod; 2015 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules

%B
7 lines changed: 7 ins; 0 del; 0 mod; 2671 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp.c

%B
876 lines changed: 876 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp.conf

%B
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp6.conf

%B
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp6ddi.c

%B
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_bind.c

%B
450 lines changed: 450 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_impl.h

%B
247 lines changed: 247 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_input.c

%B
353 lines changed: 353 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_ip.h

%B
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_opt_data.c

%B
154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_output.c

%B
375 lines changed: 375 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_socket.c

%B
579 lines changed: 579 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_stack.h

%B
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_stats.c

%B
153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_tpi.c

%B
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_tunables.c

%B
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccpddi.c

%B
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip.h

%B
7 lines changed: 7 ins; 0 del; 0 mod; 3761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip.c

%B
4 lines changed: 4 ins; 0 del; 0 mod; 15259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_if.c

%B
6 lines changed: 6 ins; 0 del; 0 mod; 19162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_input.c

%B
56 lines changed: 56 ins; 0 del; 0 mod; 3136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_output.c

%B
6 lines changed: 6 ins; 0 del; 0 mod; 2564 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ipclassifier.c

%B
165 lines changed: 164 ins; 0 del; 1 mod; 2723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip_impl.h

%B
8 lines changed: 8 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip_stack.h

%B
2 lines changed: 2 ins; 0 del; 0 mod; 449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipclassifier.h

%B
9 lines changed: 9 ins; 0 del; 0 mod; 737 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/mib2.h

%B
46 lines changed: 45 ins; 0 del; 1 mod; 1793 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/sctp/sctp_impl.h

%B
3 lines changed: 3 ins; 0 del; 0 mod; 1208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp.c

%B
1 line changed: 0 ins; 1 del; 0 mod; 4473 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_opt_data.c

%B
2 lines changed: 2 ins; 0 del; 0 mod; 1089 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_socket.c

%B
8 lines changed: 5 ins; 0 del; 3 mod; 1169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_impl.h

%B
5 lines changed: 0 ins; 5 del; 0 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_stats.h

%B
1 line changed: 0 ins; 0 del; 1 mod; 250 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tunables.c

%B
7 lines changed: 7 ins; 0 del; 0 mod; 456 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tunables.h

%B
1 line changed: 1 ins; 0 del; 0 mod; 187 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/netinet/dccp.h

%B
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/netinet/in.h

%B
1 line changed: 1 ins; 0 del; 0 mod; 1319 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/netstack.h

%B
4 lines changed: 3 ins; 0 del; 1 mod; 276 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel.shared

%B
1 line changed: 1 ins; 0 del; 0 mod; 740 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/dccp/Makefile

%B
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/dccp6/Makefile

%B
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ip/ip.global-objs.debug64

%B
18 lines changed: 18 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ip/ip.global-objs.obj64

%B
18 lines changed: 18 ins; 0 del; 0 mod; 318 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.