Code Review for il9704

Prepared by:Yuri Pankov on 2018-Aug-05 23:41 +0300 MSK
Workspace:/home/yuri/ws/il9704 (at 3c8124701608)
Compare against: origin/master (git@github.com:illumos/illumos-gate.git at db083a4d72c3)
Summary of changes: 6836 lines changed: 3040 ins; 3470 del; 326 mod; 14713 unchg
Patch of changes: il9704.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/Makefile

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/network-devices/Makefile

9704 move socket functions to libc
2 lines changed: 0 ins; 1 del; 1 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/print/bsd-sysv-commands/Makefile

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/clnt/amd64/Makefile

9704 move socket functions to libc
3 lines changed: 0 ins; 2 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/clnt/i386/Makefile

9704 move socket functions to libc
4 lines changed: 0 ins; 2 del; 2 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/clnt/sparc/Makefile

9704 move socket functions to libc
3 lines changed: 0 ins; 2 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/clnt/sparcv9/Makefile

9704 move socket functions to libc
3 lines changed: 0 ins; 2 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/srv/i386/Makefile

9704 move socket functions to libc
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/krb5/kadm5/srv/sparc/Makefile

9704 move socket functions to libc
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/Makefile.targ

9704 move socket functions to libc
5 lines changed: 5 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile

9704 move socket functions to libc
7 lines changed: 7 ins; 0 del; 0 mod; 1278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_accept.s

9704 move socket functions to libc
4 lines changed: 1 ins; 1 del; 2 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_bind.s

9704 move socket functions to libc
7 lines changed: 4 ins; 1 del; 2 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_connect.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_getpeername.s

9704 move socket functions to libc
7 lines changed: 3 ins; 1 del; 3 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_getsockname.s

9704 move socket functions to libc
7 lines changed: 3 ins; 1 del; 3 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_getsockopt.s

9704 move socket functions to libc
7 lines changed: 3 ins; 1 del; 3 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_listen.s

9704 move socket functions to libc
7 lines changed: 4 ins; 1 del; 2 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_recv.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_recvfrom.s

9704 move socket functions to libc
5 lines changed: 2 ins; 1 del; 2 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_recvmsg.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_send.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_sendmsg.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_sendto.s

9704 move socket functions to libc
5 lines changed: 2 ins; 1 del; 2 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_setsockopt.s

9704 move socket functions to libc
5 lines changed: 2 ins; 0 del; 3 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_shutdown.s

9704 move socket functions to libc
5 lines changed: 3 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_socket.s

9704 move socket functions to libc
4 lines changed: 1 ins; 1 del; 2 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/common/sys/_so_socketpair.s

9704 move socket functions to libc
6 lines changed: 3 ins; 2 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

9704 move socket functions to libc
7 lines changed: 7 ins; 0 del; 0 mod; 1358 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/inc/libc.h

9704 move socket functions to libc
10 lines changed: 0 ins; 10 del; 0 mod; 313 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

9704 move socket functions to libc
98 lines changed: 67 ins; 15 del; 16 mod; 3390 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/socket/sockatmark.c (renamed and modified from usr/src/lib/libsocket/socket/sockatmark.c)

9704 move socket functions to libc
2 lines changed: 0 ins; 2 del; 0 mod; 44 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/socket/socket.c

9704 move socket functions to libc
303 lines changed: 303 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/socket/socketpair.c (renamed and modified from usr/src/lib/libsocket/socket/socketpair.c)

9704 move socket functions to libc
6 lines changed: 0 ins; 2 del; 4 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/threads/scalls.c

9704 move socket functions to libc
23 lines changed: 1 ins; 0 del; 22 mod; 1151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdhcpagent/Makefile.com

9704 move socket functions to libc
2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libilb/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 1 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipmi/Makefile.com

9704 move socket functions to libc
2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libslp/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsocket/Makefile.com

9704 move socket functions to libc
4 lines changed: 0 ins; 2 del; 2 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsocket/common/mapfile-vers

9704 move socket functions to libc
48 lines changed: 0 ins; 0 del; 48 mod; 209 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsocket/socket/_soutil.c (deleted)

9704 move socket functions to libc
246 lines changed: 0 ins; 246 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsocket/socket/socket.c (deleted)

9704 move socket functions to libc
152 lines changed: 0 ins; 152 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libstmfproxy/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libvrrpadm/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libxnet/common/mapfile-vers

9704 move socket functions to libc
27 lines changed: 0 ins; 0 del; 27 mod; 150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/print/libipp-listener/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/print/libpapi-common/Makefile.com

9704 move socket functions to libc
1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/Makefile

9704 move socket functions to libc
43 lines changed: 42 ins; 0 del; 1 mod; 2547 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/accept.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
263 lines changed: 263 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/bind.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/connect.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
379 lines changed: 379 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/getpeername.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/getsockname.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/getsockopt.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
466 lines changed: 466 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/listen.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/recv.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
259 lines changed: 259 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/send.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
291 lines changed: 291 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/shutdown.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/sockaddr.3c (renamed and modified from usr/src/man/man3socket/sockaddr.3socket)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

9704 move socket functions to libc
218 lines changed: 9 ins; 62 del; 147 mod; 378 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/socket.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
301 lines changed: 301 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/socketpair.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw

9704 move socket functions to libc
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3socket/Makefile

9704 move socket functions to libc
45 lines changed: 0 ins; 42 del; 3 mod; 197 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/accept.3socket (deleted)

9704 move socket functions to libc
258 lines changed: 0 ins; 258 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/bind.3socket (deleted)

9704 move socket functions to libc
198 lines changed: 0 ins; 198 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/connect.3socket (deleted)

9704 move socket functions to libc
473 lines changed: 0 ins; 473 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/getpeername.3socket (deleted)

9704 move socket functions to libc
98 lines changed: 0 ins; 98 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/getsockname.3socket (deleted)

9704 move socket functions to libc
87 lines changed: 0 ins; 87 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/getsockopt.3socket (deleted)

9704 move socket functions to libc
531 lines changed: 0 ins; 531 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/listen.3socket (deleted)

9704 move socket functions to libc
100 lines changed: 0 ins; 100 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/recv.3socket (deleted)

9704 move socket functions to libc
291 lines changed: 0 ins; 291 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/send.3socket (deleted)

9704 move socket functions to libc
291 lines changed: 0 ins; 291 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/shutdown.3socket (deleted)

9704 move socket functions to libc
107 lines changed: 0 ins; 107 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/socket.3socket (deleted)

9704 move socket functions to libc
327 lines changed: 0 ins; 327 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man3socket/socketpair.3socket (deleted)

9704 move socket functions to libc
123 lines changed: 0 ins; 123 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3c.inc

9704 move socket functions to libc
25 lines changed: 25 ins; 0 del; 0 mod; 1490 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3socket.inc

9704 move socket functions to libc
28 lines changed: 0 ins; 28 del; 0 mod; 155 unchg

This code review page was prepared using /home/yuri/ws/il9704/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.