Code Review for il8548

Prepared by:Yuri Pankov on 2018-Aug-14 16:47 +0300 MSK
Workspace:/home/yuri/ws/il8548 (at 7b6081194017)
Compare against: origin/master (git@github.com:illumos/illumos-gate.git at 223ffd476e27)
Summary of changes: 733 lines changed: 723 ins; 2 del; 8 mod; 14977 unchg
Patch of changes: il8548.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/stddef_iso.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
13 lines changed: 13 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/stdlib_c11.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
20 lines changed: 20 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/string_iso.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
16 lines changed: 16 ins; 0 del; 0 mod; 154 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/stdint.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
7 lines changed: 7 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1359 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/inc/libc.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
10 lines changed: 10 ins; 0 del; 0 mod; 323 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/gen/memset_s.c 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/gen/set_constraint_handler_s.c 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
8 lines changed: 8 ins; 0 del; 0 mod; 3432 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/threads/assfail.c 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
1 line changed: 0 ins; 0 del; 1 mod; 488 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1430 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/Makefile 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
8 lines changed: 7 ins; 0 del; 1 mod; 2561 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/memset_s.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/set_constraint_handler_s.3c
man: ------ ------ ------ ------ ------ TXT HTML Raw 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3c.inc 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
6 lines changed: 6 ins; 0 del; 0 mod; 1497 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-libctest.mf 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/runfiles/default.run 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
10 lines changed: 6 ins; 2 del; 2 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/tests/Makefile 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
7 lines changed: 7 ins; 0 del; 0 mod; 111 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/memset_s.c 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/set_constraint_handler_s.c 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/feature_tests.h 

8548 want memset_s(3C)
Reviewed by: Robert Mustacchi <rm@joyent.com>
25 lines changed: 21 ins; 0 del; 4 mod; 464 unchg

This code review page was prepared using /home/yuri/ws/il8548/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.