Print this page
3749 zfs event processing should work on R/O root filesystems
Submitted by: Justin Gibbs <justing@spectralogic.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Eric Schrock <eric.schrock@delphix.com>
| Split |
Close |
| Expand all |
| Collapse all |
--- old/usr/src/uts/common/fs/zfs/spa_config.c
+++ new/usr/src/uts/common/fs/zfs/spa_config.c
1 1 /*
2 2 * CDDL HEADER START
3 3 *
4 4 * The contents of this file are subject to the terms of the
5 5 * Common Development and Distribution License (the "License").
6 6 * You may not use this file except in compliance with the License.
7 7 *
8 8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
9 9 * or http://www.opensolaris.org/os/licensing.
10 10 * See the License for the specific language governing permissions
11 11 * and limitations under the License.
12 12 *
13 13 * When distributing Covered Code, include this CDDL HEADER in each
14 14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
15 15 * If applicable, add the following below this CDDL HEADER, with the
16 16 * fields enclosed by brackets "[]" replaced with your own identifying
17 17 * information: Portions Copyright [yyyy] [name of copyright owner]
18 18 *
|
↓ open down ↓ |
18 lines elided |
↑ open up ↑ |
19 19 * CDDL HEADER END
20 20 */
21 21
22 22 /*
23 23 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
24 24 * Copyright 2011 Nexenta Systems, Inc. All rights reserved.
25 25 * Copyright (c) 2012 by Delphix. All rights reserved.
26 26 */
27 27
28 28 #include <sys/spa.h>
29 +#include <sys/fm/fs/zfs.h>
29 30 #include <sys/spa_impl.h>
30 31 #include <sys/nvpair.h>
31 32 #include <sys/uio.h>
32 33 #include <sys/fs/zfs.h>
33 34 #include <sys/vdev_impl.h>
34 35 #include <sys/zfs_ioctl.h>
35 36 #include <sys/utsname.h>
36 37 #include <sys/systeminfo.h>
37 38 #include <sys/sunddi.h>
38 39 #include <sys/zfeature.h>
39 40 #ifdef _KERNEL
40 41 #include <sys/kobj.h>
41 42 #include <sys/zone.h>
42 43 #endif
43 44
44 45 /*
45 46 * Pool configuration repository.
46 47 *
47 48 * Pool configuration is stored as a packed nvlist on the filesystem. By
48 49 * default, all pools are stored in /etc/zfs/zpool.cache and loaded on boot
49 50 * (when the ZFS module is loaded). Pools can also have the 'cachefile'
50 51 * property set that allows them to be stored in an alternate location until
51 52 * the control of external software.
52 53 *
53 54 * For each cache file, we have a single nvlist which holds all the
54 55 * configuration information. When the module loads, we read this information
55 56 * from /etc/zfs/zpool.cache and populate the SPA namespace. This namespace is
56 57 * maintained independently in spa.c. Whenever the namespace is modified, or
57 58 * the configuration of a pool is changed, we call spa_config_sync(), which
58 59 * walks through all the active pools and writes the configuration to disk.
59 60 */
60 61
61 62 static uint64_t spa_config_generation = 1;
62 63
63 64 /*
64 65 * This can be overridden in userland to preserve an alternate namespace for
65 66 * userland pools when doing testing.
66 67 */
67 68 const char *spa_config_path = ZPOOL_CACHE;
68 69
69 70 /*
70 71 * Called when the module is first loaded, this routine loads the configuration
71 72 * file into the SPA namespace. It does not actually open or load the pools; it
72 73 * only populates the namespace.
73 74 */
74 75 void
75 76 spa_config_load(void)
76 77 {
77 78 void *buf = NULL;
78 79 nvlist_t *nvlist, *child;
79 80 nvpair_t *nvpair;
80 81 char *pathname;
81 82 struct _buf *file;
82 83 uint64_t fsize;
83 84
84 85 /*
85 86 * Open the configuration file.
86 87 */
87 88 pathname = kmem_alloc(MAXPATHLEN, KM_SLEEP);
88 89
89 90 (void) snprintf(pathname, MAXPATHLEN, "%s%s",
90 91 (rootdir != NULL) ? "./" : "", spa_config_path);
91 92
92 93 file = kobj_open_file(pathname);
93 94
94 95 kmem_free(pathname, MAXPATHLEN);
95 96
96 97 if (file == (struct _buf *)-1)
97 98 return;
98 99
99 100 if (kobj_get_filesize(file, &fsize) != 0)
100 101 goto out;
101 102
102 103 buf = kmem_alloc(fsize, KM_SLEEP);
103 104
104 105 /*
105 106 * Read the nvlist from the file.
106 107 */
107 108 if (kobj_read_file(file, buf, fsize, 0) < 0)
108 109 goto out;
109 110
110 111 /*
111 112 * Unpack the nvlist.
112 113 */
113 114 if (nvlist_unpack(buf, fsize, &nvlist, KM_SLEEP) != 0)
114 115 goto out;
115 116
116 117 /*
117 118 * Iterate over all elements in the nvlist, creating a new spa_t for
118 119 * each one with the specified configuration.
119 120 */
120 121 mutex_enter(&spa_namespace_lock);
121 122 nvpair = NULL;
122 123 while ((nvpair = nvlist_next_nvpair(nvlist, nvpair)) != NULL) {
123 124 if (nvpair_type(nvpair) != DATA_TYPE_NVLIST)
124 125 continue;
125 126
126 127 VERIFY(nvpair_value_nvlist(nvpair, &child) == 0);
127 128
128 129 if (spa_lookup(nvpair_name(nvpair)) != NULL)
129 130 continue;
130 131 (void) spa_add(nvpair_name(nvpair), child, NULL);
131 132 }
132 133 mutex_exit(&spa_namespace_lock);
|
↓ open down ↓ |
94 lines elided |
↑ open up ↑ |
133 134
134 135 nvlist_free(nvlist);
135 136
136 137 out:
137 138 if (buf != NULL)
138 139 kmem_free(buf, fsize);
139 140
140 141 kobj_close_file(file);
141 142 }
142 143
143 -static void
144 +static int
144 145 spa_config_write(spa_config_dirent_t *dp, nvlist_t *nvl)
145 146 {
146 147 size_t buflen;
147 148 char *buf;
148 149 vnode_t *vp;
149 150 int oflags = FWRITE | FTRUNC | FCREAT | FOFFMAX;
150 151 char *temp;
152 + int err;
151 153
152 154 /*
153 155 * If the nvlist is empty (NULL), then remove the old cachefile.
154 156 */
155 157 if (nvl == NULL) {
156 - (void) vn_remove(dp->scd_path, UIO_SYSSPACE, RMFILE);
157 - return;
158 + err = vn_remove(dp->scd_path, UIO_SYSSPACE, RMFILE);
159 + return (err);
158 160 }
159 161
160 162 /*
161 163 * Pack the configuration into a buffer.
162 164 */
163 165 VERIFY(nvlist_size(nvl, &buflen, NV_ENCODE_XDR) == 0);
164 166
165 167 buf = kmem_alloc(buflen, KM_SLEEP);
166 168 temp = kmem_zalloc(MAXPATHLEN, KM_SLEEP);
167 169
168 170 VERIFY(nvlist_pack(nvl, &buf, &buflen, NV_ENCODE_XDR,
169 171 KM_SLEEP) == 0);
170 172
171 173 /*
172 174 * Write the configuration to disk. We need to do the traditional
173 175 * 'write to temporary file, sync, move over original' to make sure we
174 176 * always have a consistent view of the data.
175 177 */
176 178 (void) snprintf(temp, MAXPATHLEN, "%s.tmp", dp->scd_path);
177 179
178 - if (vn_open(temp, UIO_SYSSPACE, oflags, 0644, &vp, CRCREAT, 0) == 0) {
179 - if (vn_rdwr(UIO_WRITE, vp, buf, buflen, 0, UIO_SYSSPACE,
180 - 0, RLIM64_INFINITY, kcred, NULL) == 0 &&
181 - VOP_FSYNC(vp, FSYNC, kcred, NULL) == 0) {
182 - (void) vn_rename(temp, dp->scd_path, UIO_SYSSPACE);
183 - }
180 + err = vn_open(temp, UIO_SYSSPACE, oflags, 0644, &vp, CRCREAT, 0);
181 + if (err == 0) {
182 + err = vn_rdwr(UIO_WRITE, vp, buf, buflen, 0, UIO_SYSSPACE,
183 + 0, RLIM64_INFINITY, kcred, NULL);
184 + if (err == 0)
185 + err = VOP_FSYNC(vp, FSYNC, kcred, NULL);
186 + if (err == 0)
187 + err = vn_rename(temp, dp->scd_path, UIO_SYSSPACE);
184 188 (void) VOP_CLOSE(vp, oflags, 1, 0, kcred, NULL);
185 189 VN_RELE(vp);
186 190 }
187 191
188 192 (void) vn_remove(temp, UIO_SYSSPACE, RMFILE);
189 193
190 194 kmem_free(buf, buflen);
191 195 kmem_free(temp, MAXPATHLEN);
196 + return (err);
192 197 }
193 198
194 199 /*
195 200 * Synchronize pool configuration to disk. This must be called with the
196 201 * namespace lock held.
197 202 */
198 203 void
199 204 spa_config_sync(spa_t *target, boolean_t removing, boolean_t postsysevent)
200 205 {
201 206 spa_config_dirent_t *dp, *tdp;
202 207 nvlist_t *nvl;
208 + boolean_t ccw_failure;
209 + int error;
203 210
204 211 ASSERT(MUTEX_HELD(&spa_namespace_lock));
205 212
206 213 if (rootdir == NULL || !(spa_mode_global & FWRITE))
207 214 return;
208 215
209 216 /*
210 217 * Iterate over all cachefiles for the pool, past or present. When the
211 218 * cachefile is changed, the new one is pushed onto this list, allowing
212 219 * us to update previous cachefiles that no longer contain this pool.
213 220 */
221 + ccw_failure = B_FALSE;
214 222 for (dp = list_head(&target->spa_config_list); dp != NULL;
215 223 dp = list_next(&target->spa_config_list, dp)) {
216 224 spa_t *spa = NULL;
217 225 if (dp->scd_path == NULL)
218 226 continue;
219 227
220 228 /*
221 229 * Iterate over all pools, adding any matching pools to 'nvl'.
222 230 */
223 231 nvl = NULL;
224 232 while ((spa = spa_next(spa)) != NULL) {
225 233 /*
226 234 * Skip over our own pool if we're about to remove
227 235 * ourselves from the spa namespace or any pool that
228 236 * is readonly. Since we cannot guarantee that a
229 237 * readonly pool would successfully import upon reboot,
230 238 * we don't allow them to be written to the cache file.
231 239 */
232 240 if ((spa == target && removing) ||
233 241 !spa_writeable(spa))
234 242 continue;
235 243
236 244 mutex_enter(&spa->spa_props_lock);
237 245 tdp = list_head(&spa->spa_config_list);
238 246 if (spa->spa_config == NULL ||
239 247 tdp->scd_path == NULL ||
240 248 strcmp(tdp->scd_path, dp->scd_path) != 0) {
241 249 mutex_exit(&spa->spa_props_lock);
242 250 continue;
243 251 }
|
↓ open down ↓ |
20 lines elided |
↑ open up ↑ |
244 252
245 253 if (nvl == NULL)
246 254 VERIFY(nvlist_alloc(&nvl, NV_UNIQUE_NAME,
247 255 KM_SLEEP) == 0);
248 256
249 257 VERIFY(nvlist_add_nvlist(nvl, spa->spa_name,
250 258 spa->spa_config) == 0);
251 259 mutex_exit(&spa->spa_props_lock);
252 260 }
253 261
254 - spa_config_write(dp, nvl);
262 + error = spa_config_write(dp, nvl);
263 + if (error != 0)
264 + ccw_failure = B_TRUE;
255 265 nvlist_free(nvl);
256 266 }
257 267
268 + if (ccw_failure) {
269 + /*
270 + * Keep trying so that configuration data is
271 + * written if/when any temporary filesystem
272 + * resource issues are resolved.
273 + */
274 + if (target->spa_ccw_fail_time == 0) {
275 + zfs_ereport_post(FM_EREPORT_ZFS_CONFIG_CACHE_WRITE,
276 + target, NULL, NULL, 0, 0);
277 + }
278 + target->spa_ccw_fail_time = gethrtime();
279 + spa_async_request(target, SPA_ASYNC_CONFIG_UPDATE);
280 + } else {
281 + /*
282 + * Do not rate limit future attempts to update
283 + * the config cache.
284 + */
285 + target->spa_ccw_fail_time = 0;
286 + }
287 +
258 288 /*
259 289 * Remove any config entries older than the current one.
260 290 */
261 291 dp = list_head(&target->spa_config_list);
262 292 while ((tdp = list_next(&target->spa_config_list, dp)) != NULL) {
263 293 list_remove(&target->spa_config_list, tdp);
264 294 if (tdp->scd_path != NULL)
265 295 spa_strfree(tdp->scd_path);
266 296 kmem_free(tdp, sizeof (spa_config_dirent_t));
267 297 }
268 298
269 299 spa_config_generation++;
270 300
271 301 if (postsysevent)
272 302 spa_event_notify(target, NULL, ESC_ZFS_CONFIG_SYNC);
273 303 }
274 304
275 305 /*
276 306 * Sigh. Inside a local zone, we don't have access to /etc/zfs/zpool.cache,
277 307 * and we don't want to allow the local zone to see all the pools anyway.
278 308 * So we have to invent the ZFS_IOC_CONFIG ioctl to grab the configuration
279 309 * information for all pool visible within the zone.
280 310 */
281 311 nvlist_t *
282 312 spa_all_configs(uint64_t *generation)
283 313 {
284 314 nvlist_t *pools;
285 315 spa_t *spa = NULL;
286 316
287 317 if (*generation == spa_config_generation)
288 318 return (NULL);
289 319
290 320 VERIFY(nvlist_alloc(&pools, NV_UNIQUE_NAME, KM_SLEEP) == 0);
291 321
292 322 mutex_enter(&spa_namespace_lock);
293 323 while ((spa = spa_next(spa)) != NULL) {
294 324 if (INGLOBALZONE(curproc) ||
295 325 zone_dataset_visible(spa_name(spa), NULL)) {
296 326 mutex_enter(&spa->spa_props_lock);
297 327 VERIFY(nvlist_add_nvlist(pools, spa_name(spa),
298 328 spa->spa_config) == 0);
299 329 mutex_exit(&spa->spa_props_lock);
300 330 }
301 331 }
302 332 *generation = spa_config_generation;
303 333 mutex_exit(&spa_namespace_lock);
304 334
305 335 return (pools);
306 336 }
307 337
308 338 void
309 339 spa_config_set(spa_t *spa, nvlist_t *config)
310 340 {
311 341 mutex_enter(&spa->spa_props_lock);
312 342 if (spa->spa_config != NULL)
313 343 nvlist_free(spa->spa_config);
314 344 spa->spa_config = config;
315 345 mutex_exit(&spa->spa_props_lock);
316 346 }
317 347
318 348 /*
319 349 * Generate the pool's configuration based on the current in-core state.
320 350 * We infer whether to generate a complete config or just one top-level config
321 351 * based on whether vd is the root vdev.
322 352 */
323 353 nvlist_t *
324 354 spa_config_generate(spa_t *spa, vdev_t *vd, uint64_t txg, int getstats)
325 355 {
326 356 nvlist_t *config, *nvroot;
327 357 vdev_t *rvd = spa->spa_root_vdev;
328 358 unsigned long hostid = 0;
329 359 boolean_t locked = B_FALSE;
330 360 uint64_t split_guid;
331 361
332 362 if (vd == NULL) {
333 363 vd = rvd;
334 364 locked = B_TRUE;
335 365 spa_config_enter(spa, SCL_CONFIG | SCL_STATE, FTAG, RW_READER);
336 366 }
337 367
338 368 ASSERT(spa_config_held(spa, SCL_CONFIG | SCL_STATE, RW_READER) ==
339 369 (SCL_CONFIG | SCL_STATE));
340 370
341 371 /*
342 372 * If txg is -1, report the current value of spa->spa_config_txg.
343 373 */
344 374 if (txg == -1ULL)
345 375 txg = spa->spa_config_txg;
346 376
347 377 VERIFY(nvlist_alloc(&config, NV_UNIQUE_NAME, KM_SLEEP) == 0);
348 378
349 379 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_VERSION,
350 380 spa_version(spa)) == 0);
351 381 VERIFY(nvlist_add_string(config, ZPOOL_CONFIG_POOL_NAME,
352 382 spa_name(spa)) == 0);
353 383 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_POOL_STATE,
354 384 spa_state(spa)) == 0);
355 385 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_POOL_TXG,
356 386 txg) == 0);
357 387 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_POOL_GUID,
358 388 spa_guid(spa)) == 0);
359 389 VERIFY(spa->spa_comment == NULL || nvlist_add_string(config,
360 390 ZPOOL_CONFIG_COMMENT, spa->spa_comment) == 0);
361 391
362 392
363 393 #ifdef _KERNEL
364 394 hostid = zone_get_hostid(NULL);
365 395 #else /* _KERNEL */
366 396 /*
367 397 * We're emulating the system's hostid in userland, so we can't use
368 398 * zone_get_hostid().
369 399 */
370 400 (void) ddi_strtoul(hw_serial, NULL, 10, &hostid);
371 401 #endif /* _KERNEL */
372 402 if (hostid != 0) {
373 403 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_HOSTID,
374 404 hostid) == 0);
375 405 }
376 406 VERIFY(nvlist_add_string(config, ZPOOL_CONFIG_HOSTNAME,
377 407 utsname.nodename) == 0);
378 408
379 409 if (vd != rvd) {
380 410 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_TOP_GUID,
381 411 vd->vdev_top->vdev_guid) == 0);
382 412 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_GUID,
383 413 vd->vdev_guid) == 0);
384 414 if (vd->vdev_isspare)
385 415 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_IS_SPARE,
386 416 1ULL) == 0);
387 417 if (vd->vdev_islog)
388 418 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_IS_LOG,
389 419 1ULL) == 0);
390 420 vd = vd->vdev_top; /* label contains top config */
391 421 } else {
392 422 /*
393 423 * Only add the (potentially large) split information
394 424 * in the mos config, and not in the vdev labels
395 425 */
396 426 if (spa->spa_config_splitting != NULL)
397 427 VERIFY(nvlist_add_nvlist(config, ZPOOL_CONFIG_SPLIT,
398 428 spa->spa_config_splitting) == 0);
399 429 }
400 430
401 431 /*
402 432 * Add the top-level config. We even add this on pools which
403 433 * don't support holes in the namespace.
404 434 */
405 435 vdev_top_config_generate(spa, config);
406 436
407 437 /*
408 438 * If we're splitting, record the original pool's guid.
409 439 */
410 440 if (spa->spa_config_splitting != NULL &&
411 441 nvlist_lookup_uint64(spa->spa_config_splitting,
412 442 ZPOOL_CONFIG_SPLIT_GUID, &split_guid) == 0) {
413 443 VERIFY(nvlist_add_uint64(config, ZPOOL_CONFIG_SPLIT_GUID,
414 444 split_guid) == 0);
415 445 }
416 446
417 447 nvroot = vdev_config_generate(spa, vd, getstats, 0);
418 448 VERIFY(nvlist_add_nvlist(config, ZPOOL_CONFIG_VDEV_TREE, nvroot) == 0);
419 449 nvlist_free(nvroot);
420 450
421 451 /*
422 452 * Store what's necessary for reading the MOS in the label.
423 453 */
424 454 VERIFY(nvlist_add_nvlist(config, ZPOOL_CONFIG_FEATURES_FOR_READ,
425 455 spa->spa_label_features) == 0);
426 456
427 457 if (getstats && spa_load_state(spa) == SPA_LOAD_NONE) {
428 458 ddt_histogram_t *ddh;
429 459 ddt_stat_t *dds;
430 460 ddt_object_t *ddo;
431 461
432 462 ddh = kmem_zalloc(sizeof (ddt_histogram_t), KM_SLEEP);
433 463 ddt_get_dedup_histogram(spa, ddh);
434 464 VERIFY(nvlist_add_uint64_array(config,
435 465 ZPOOL_CONFIG_DDT_HISTOGRAM,
436 466 (uint64_t *)ddh, sizeof (*ddh) / sizeof (uint64_t)) == 0);
437 467 kmem_free(ddh, sizeof (ddt_histogram_t));
438 468
439 469 ddo = kmem_zalloc(sizeof (ddt_object_t), KM_SLEEP);
440 470 ddt_get_dedup_object_stats(spa, ddo);
441 471 VERIFY(nvlist_add_uint64_array(config,
442 472 ZPOOL_CONFIG_DDT_OBJ_STATS,
443 473 (uint64_t *)ddo, sizeof (*ddo) / sizeof (uint64_t)) == 0);
444 474 kmem_free(ddo, sizeof (ddt_object_t));
445 475
446 476 dds = kmem_zalloc(sizeof (ddt_stat_t), KM_SLEEP);
447 477 ddt_get_dedup_stats(spa, dds);
448 478 VERIFY(nvlist_add_uint64_array(config,
449 479 ZPOOL_CONFIG_DDT_STATS,
450 480 (uint64_t *)dds, sizeof (*dds) / sizeof (uint64_t)) == 0);
451 481 kmem_free(dds, sizeof (ddt_stat_t));
452 482 }
453 483
454 484 if (locked)
455 485 spa_config_exit(spa, SCL_CONFIG | SCL_STATE, FTAG);
456 486
457 487 return (config);
458 488 }
459 489
460 490 /*
461 491 * Update all disk labels, generate a fresh config based on the current
462 492 * in-core state, and sync the global config cache (do not sync the config
463 493 * cache if this is a booting rootpool).
464 494 */
465 495 void
466 496 spa_config_update(spa_t *spa, int what)
467 497 {
468 498 vdev_t *rvd = spa->spa_root_vdev;
469 499 uint64_t txg;
470 500 int c;
471 501
472 502 ASSERT(MUTEX_HELD(&spa_namespace_lock));
473 503
474 504 spa_config_enter(spa, SCL_ALL, FTAG, RW_WRITER);
475 505 txg = spa_last_synced_txg(spa) + 1;
476 506 if (what == SPA_CONFIG_UPDATE_POOL) {
477 507 vdev_config_dirty(rvd);
478 508 } else {
479 509 /*
480 510 * If we have top-level vdevs that were added but have
481 511 * not yet been prepared for allocation, do that now.
482 512 * (It's safe now because the config cache is up to date,
483 513 * so it will be able to translate the new DVAs.)
484 514 * See comments in spa_vdev_add() for full details.
485 515 */
486 516 for (c = 0; c < rvd->vdev_children; c++) {
487 517 vdev_t *tvd = rvd->vdev_child[c];
488 518 if (tvd->vdev_ms_array == 0)
489 519 vdev_metaslab_set_size(tvd);
490 520 vdev_expand(tvd, txg);
491 521 }
492 522 }
493 523 spa_config_exit(spa, SCL_ALL, FTAG);
494 524
495 525 /*
496 526 * Wait for the mosconfig to be regenerated and synced.
497 527 */
498 528 txg_wait_synced(spa->spa_dsl_pool, txg);
499 529
500 530 /*
501 531 * Update the global config cache to reflect the new mosconfig.
502 532 */
503 533 if (!spa->spa_is_root)
504 534 spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL);
505 535
506 536 if (what == SPA_CONFIG_UPDATE_POOL)
507 537 spa_config_update(spa, SPA_CONFIG_UPDATE_VDEVS);
508 538 }
|
↓ open down ↓ |
241 lines elided |
↑ open up ↑ |
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX