Print this page
3742 zfs comments need cleaner, more consistent style
Submitted by: Will Andrews <willa@spectralogic.com>
Submitted by: Alan Somers <alans@spectralogic.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Eric Schrock <eric.schrock@delphix.com>
*** 954,966 ****
kmem_free(vps, sizeof (*vps));
}
}
/*
! * Determine whether this device is accessible by reading and writing
! * to several known locations: the pad regions of each vdev label
! * but the first (which we leave alone in case it contains a VTOC).
*/
zio_t *
vdev_probe(vdev_t *vd, zio_t *zio)
{
spa_t *spa = vd->vdev_spa;
--- 954,968 ----
kmem_free(vps, sizeof (*vps));
}
}
/*
! * Determine whether this device is accessible.
! *
! * Read and write to several known locations: the pad regions of each
! * vdev label but the first, which we leave alone in case it contains
! * a VTOC.
*/
zio_t *
vdev_probe(vdev_t *vd, zio_t *zio)
{
spa_t *spa = vd->vdev_spa;
*** 2177,2190 ****
return (spa_vdev_state_exit(spa, vd, 0));
}
/*
! * Online the given vdev. If 'unspare' is set, it implies two things. First,
! * any attached spare device should be detached when the device finishes
! * resilvering. Second, the online should be treated like a 'test' online case,
! * so no FMA events are generated if the device fails to open.
*/
int
vdev_online(spa_t *spa, uint64_t guid, uint64_t flags, vdev_state_t *newstate)
{
vdev_t *vd, *tvd, *pvd, *rvd = spa->spa_root_vdev;
--- 2179,2194 ----
return (spa_vdev_state_exit(spa, vd, 0));
}
/*
! * Online the given vdev.
! *
! * If 'ZFS_ONLINE_UNSPARE' is set, it implies two things. First, any attached
! * spare device should be detached when the device finishes resilvering.
! * Second, the online should be treated like a 'test' online case, so no FMA
! * events are generated if the device fails to open.
*/
int
vdev_online(spa_t *spa, uint64_t guid, uint64_t flags, vdev_state_t *newstate)
{
vdev_t *vd, *tvd, *pvd, *rvd = spa->spa_root_vdev;