Print this page
3742 zfs comments need cleaner, more consistent style
Submitted by:   Will Andrews <willa@spectralogic.com>
Submitted by:   Alan Somers <alans@spectralogic.com>
Reviewed by:    Matthew Ahrens <mahrens@delphix.com>
Reviewed by:    George Wilson <george.wilson@delphix.com>
Reviewed by:    Eric Schrock <eric.schrock@delphix.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/zfs/sys/zfs_acl.h
          +++ new/usr/src/uts/common/fs/zfs/sys/zfs_acl.h
↓ open down ↓ 38 lines elided ↑ open up ↑
  39   39  #endif
  40   40  
  41   41  struct znode_phys;
  42   42  
  43   43  #define ACE_SLOT_CNT    6
  44   44  #define ZFS_ACL_VERSION_INITIAL 0ULL
  45   45  #define ZFS_ACL_VERSION_FUID    1ULL
  46   46  #define ZFS_ACL_VERSION         ZFS_ACL_VERSION_FUID
  47   47  
  48   48  /*
  49      - * ZFS ACLs are store in various forms.
       49 + * ZFS ACLs (Access Control Lists) are stored in various forms.
       50 + *
  50   51   * Files created with ACL version ZFS_ACL_VERSION_INITIAL
  51   52   * will all be created with fixed length ACEs of type
  52   53   * zfs_oldace_t.
  53   54   *
  54   55   * Files with ACL version ZFS_ACL_VERSION_FUID will be created
  55   56   * with various sized ACEs.  The abstraction entries will utilize
  56   57   * zfs_ace_hdr_t, normal user/group entries will use zfs_ace_t
  57   58   * and some specialized CIFS ACEs will use zfs_object_ace_t.
  58   59   */
  59   60  
↓ open down ↓ 69 lines elided ↑ open up ↑
 129  130                              uint16_t flags); /* set flags */
 130  131          uint16_t        (*ace_type_get)(void *acep); /* get type */
 131  132          void            (*ace_type_set)(void *acep,
 132  133                              uint16_t type); /* set type */
 133  134          uint64_t        (*ace_who_get)(void *acep); /* get who/fuid */
 134  135          void            (*ace_who_set)(void *acep,
 135  136                              uint64_t who); /* set who/fuid */
 136  137          size_t          (*ace_size)(void *acep); /* how big is this ace */
 137  138          size_t          (*ace_abstract_size)(void); /* sizeof abstract entry */
 138  139          int             (*ace_mask_off)(void); /* off of access mask in ace */
      140 +        /* ptr to data if any */
 139  141          int             (*ace_data)(void *acep, void **datap);
 140      -                            /* ptr to data if any */
 141  142  } acl_ops_t;
 142  143  
 143  144  /*
 144  145   * A zfs_acl_t structure is composed of a list of zfs_acl_node_t's.
 145  146   * Each node will have one or more ACEs associated with it.  You will
 146  147   * only have multiple nodes during a chmod operation.   Normally only
 147  148   * one node is required.
 148  149   */
 149  150  typedef struct zfs_acl_node {
 150  151          list_node_t     z_next;         /* Next chunk of ACEs */
↓ open down ↓ 95 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX