Print this page
3742 zfs comments need cleaner, more consistent style
Submitted by:   Will Andrews <willa@spectralogic.com>
Submitted by:   Alan Somers <alans@spectralogic.com>
Reviewed by:    Matthew Ahrens <mahrens@delphix.com>
Reviewed by:    George Wilson <george.wilson@delphix.com>
Reviewed by:    Eric Schrock <eric.schrock@delphix.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/zfs/sys/zil.h
          +++ new/usr/src/uts/common/fs/zfs/sys/zil.h
↓ open down ↓ 234 lines elided ↑ open up ↑
 235  235   * information will be used to construct real FUIDs (and bypass idmap,
 236  236   * since it may not be available).
 237  237   */
 238  238  
 239  239  /*
 240  240   * Log record for creates with optional ACL
 241  241   * This log record is also used for recording any FUID
 242  242   * information needed for replaying the create.  If the
 243  243   * file doesn't have any actual ACEs then the lr_aclcnt
 244  244   * would be zero.
      245 + *
      246 + * After lr_acl_flags, there are a lr_acl_bytes number of variable sized ace's.
      247 + * If create is also setting xvattr's, then acl data follows xvattr.
      248 + * If ACE FUIDs are needed then they will follow the xvattr_t.  Following
      249 + * the FUIDs will be the domain table information.  The FUIDs for the owner
      250 + * and group will be in lr_create.  Name follows ACL data.
 245  251   */
 246  252  typedef struct {
 247  253          lr_create_t     lr_create;      /* common create portion */
 248  254          uint64_t        lr_aclcnt;      /* number of ACEs in ACL */
 249  255          uint64_t        lr_domcnt;      /* number of unique domains */
 250  256          uint64_t        lr_fuidcnt;     /* number of real fuids */
 251  257          uint64_t        lr_acl_bytes;   /* number of bytes in ACL */
 252  258          uint64_t        lr_acl_flags;   /* ACL flags */
 253      -        /* lr_acl_bytes number of variable sized ace's follows */
 254      -        /* if create is also setting xvattr's, then acl data follows xvattr */
 255      -        /* if ACE FUIDs are needed then they will follow the xvattr_t */
 256      -        /* Following the FUIDs will be the domain table information. */
 257      -        /* The FUIDs for the owner and group will be in the lr_create */
 258      -        /* portion of the record. */
 259      -        /* name follows ACL data */
 260  259  } lr_acl_create_t;
 261  260  
 262  261  typedef struct {
 263  262          lr_t            lr_common;      /* common portion of log record */
 264  263          uint64_t        lr_doid;        /* obj id of directory */
 265  264          /* name of object to remove follows this */
 266  265  } lr_remove_t;
 267  266  
 268  267  typedef struct {
 269  268          lr_t            lr_common;      /* common portion of log record */
↓ open down ↓ 161 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX