Print this page
3742 zfs comments need cleaner, more consistent style
Submitted by:   Will Andrews <willa@spectralogic.com>
Submitted by:   Alan Somers <alans@spectralogic.com>
Reviewed by:    Matthew Ahrens <mahrens@delphix.com>
Reviewed by:    George Wilson <george.wilson@delphix.com>
Reviewed by:    Eric Schrock <eric.schrock@delphix.com>

@@ -148,26 +148,21 @@
         sa_attr_type_t  *sa_user_table; /* user name->attr mapping table */
 };
 
 /*
  * header for all bonus and spill buffers.
+ *
  * The header has a fixed portion with a variable number
  * of "lengths" depending on the number of variable sized
  * attribues which are determined by the "layout number"
  */
 
 #define SA_MAGIC        0x2F505A  /* ZFS SA */
 typedef struct sa_hdr_phys {
         uint32_t sa_magic;
-        uint16_t sa_layout_info;  /* Encoded with hdrsize and layout number */
-        uint16_t sa_lengths[1]; /* optional sizes for variable length attrs */
-        /* ... Data follows the lengths.  */
-} sa_hdr_phys_t;
-
-/*
- * sa_hdr_phys -> sa_layout_info
- *
+        /*
+         * Encoded with hdrsize and layout number as follows:
  * 16      10       0
  * +--------+-------+
  * | hdrsz  |layout |
  * +--------+-------+
  *

@@ -178,10 +173,14 @@
  * For example.
  * hdrsz of 1 ==> 8 byte header
  *          2 ==> 16 byte header
  *
  */
+        uint16_t sa_layout_info;
+        uint16_t sa_lengths[1]; /* optional sizes for variable length attrs */
+        /* ... Data follows the lengths.  */
+} sa_hdr_phys_t;
 
 #define SA_HDR_LAYOUT_NUM(hdr) BF32_GET(hdr->sa_layout_info, 0, 10)
 #define SA_HDR_SIZE(hdr) BF32_GET_SB(hdr->sa_layout_info, 10, 6, 3, 0)
 #define SA_HDR_LAYOUT_INFO_ENCODE(x, num, size) \
 { \