Print this page
3742 zfs comments need cleaner, more consistent style
Submitted by:   Will Andrews <willa@spectralogic.com>
Submitted by:   Alan Somers <alans@spectralogic.com>
Reviewed by:    Matthew Ahrens <mahrens@delphix.com>
Reviewed by:    George Wilson <george.wilson@delphix.com>
Reviewed by:    Eric Schrock <eric.schrock@delphix.com>

*** 61,80 **** /* * On-disk ddt entry: key (name) and physical storage (value). */ typedef struct ddt_key { zio_cksum_t ddk_cksum; /* 256-bit block checksum */ ! uint64_t ddk_prop; /* LSIZE, PSIZE, compression */ ! } ddt_key_t; ! ! /* ! * ddk_prop layout: ! * * +-------+-------+-------+-------+-------+-------+-------+-------+ * | 0 | 0 | 0 | comp | PSIZE | LSIZE | * +-------+-------+-------+-------+-------+-------+-------+-------+ */ #define DDK_GET_LSIZE(ddk) \ BF64_GET_SB((ddk)->ddk_prop, 0, 16, SPA_MINBLOCKSHIFT, 1) #define DDK_SET_LSIZE(ddk, x) \ BF64_SET_SB((ddk)->ddk_prop, 0, 16, SPA_MINBLOCKSHIFT, 1, x) --- 61,79 ---- /* * On-disk ddt entry: key (name) and physical storage (value). */ typedef struct ddt_key { zio_cksum_t ddk_cksum; /* 256-bit block checksum */ ! /* ! * Encoded with logical & physical size, and compression, as follows: * +-------+-------+-------+-------+-------+-------+-------+-------+ * | 0 | 0 | 0 | comp | PSIZE | LSIZE | * +-------+-------+-------+-------+-------+-------+-------+-------+ */ + uint64_t ddk_prop; + } ddt_key_t; + #define DDK_GET_LSIZE(ddk) \ BF64_GET_SB((ddk)->ddk_prop, 0, 16, SPA_MINBLOCKSHIFT, 1) #define DDK_SET_LSIZE(ddk, x) \ BF64_SET_SB((ddk)->ddk_prop, 0, 16, SPA_MINBLOCKSHIFT, 1, x)