Code Review for illumos-gate.git

Prepared by:Super-User (root) on 2013-Oct-07 19:17 +0100 BST
Workspace:/code/illumos-gate.git (at 6db7ce375b6c)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 7fdd916c474e)
Summary of changes: 6864 lines changed: 6783 ins; 17 del; 64 mod; 47473 unchg
Patch of changes: illumos-gate.git.patch
Printable review: illumos-gate.git.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/edonr/edonr.c

4185 New hash algorithm support
730 lines changed: 730 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/edonr/edonr_byteorder.h

4185 New hash algorithm support
218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/edonr/test/Makefile

4185 New hash algorithm support
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/edonr/test/edonr_test.c

4185 New hash algorithm support
211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/sha2/sha2.c

4185 New hash algorithm support
41 lines changed: 39 ins; 1 del; 1 mod; 920 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/test/Makefile

4185 New hash algorithm support
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/test/sha2_test.c

4185 New hash algorithm support
251 lines changed: 251 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/THIRDPARTYLICENSE

4185 New hash algorithm support
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/THIRDPARTYLICENSE.descrip

4185 New hash algorithm support
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/skein.c

4185 New hash algorithm support
915 lines changed: 915 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/skein_block.c

4185 New hash algorithm support
767 lines changed: 767 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/skein_impl.h

4185 New hash algorithm support
273 lines changed: 273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/skein_iv.h

4185 New hash algorithm support
189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/skein_port.h

4185 New hash algorithm support
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/test/Makefile

4185 New hash algorithm support
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/skein/test/skein_test.c

4185 New hash algorithm support
332 lines changed: 332 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfeature_common.c

4185 New hash algorithm support
9 lines changed: 9 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfeature_common.h

4185 New hash algorithm support
3 lines changed: 3 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfs_fletcher.c

4185 New hash algorithm support
15 lines changed: 11 ins; 0 del; 4 mod; 242 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfs_fletcher.h

4185 New hash algorithm support
11 lines changed: 7 ins; 0 del; 4 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/zfs/zfs_prop.c

4185 New hash algorithm support
16 lines changed: 12 ins; 0 del; 4 mod; 626 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/capability

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/stage2/fsys_zfs.c

4185 New hash algorithm support
3 lines changed: 2 ins; 0 del; 1 mod; 1797 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/stage2/fsys_zfs.h

4185 New hash algorithm support
1 line changed: 1 ins; 0 del; 0 mod; 221 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/stage2/zfs-include/zio.h

4185 New hash algorithm support
1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/stage2/zfs_sha256.c

4185 New hash algorithm support
186 lines changed: 164 ins; 10 del; 12 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile.com

4185 New hash algorithm support
6 lines changed: 4 ins; 0 del; 2 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile.targ

4185 New hash algorithm support
9 lines changed: 9 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/amd64/Makefile

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/common/mapfile-vers

4185 New hash algorithm support
23 lines changed: 23 ins; 0 del; 0 mod; 80 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmd/common/skein.h

4185 New hash algorithm support
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/i386/Makefile

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/inc.flg

4185 New hash algorithm support
3 lines changed: 2 ins; 0 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/sparc/Makefile

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/sparcv9/Makefile

4185 New hash algorithm support
2 lines changed: 1 ins; 0 del; 1 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_dataset.c

4185 New hash algorithm support
6 lines changed: 6 ins; 0 del; 0 mod; 4503 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/zfs.1m

4185 New hash algorithm support
6 lines changed: 4 ins; 0 del; 2 mod; 4017 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/zpool-features.5

4185 New hash algorithm support
107 lines changed: 107 ins; 0 del; 0 mod; 276 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

4185 New hash algorithm support
4 lines changed: 4 ins; 0 del; 0 mod; 2139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.mf

4185 New hash algorithm support
11 lines changed: 11 ins; 0 del; 0 mod; 911 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

4185 New hash algorithm support
6 lines changed: 6 ins; 0 del; 0 mod; 2079 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules

4185 New hash algorithm support
15 lines changed: 15 ins; 0 del; 0 mod; 2720 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/crypto/io/edonr_mod.c

4185 New hash algorithm support
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/crypto/io/skein_mod.c

4185 New hash algorithm support
828 lines changed: 828 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/arc.c

4185 New hash algorithm support
3 lines changed: 0 ins; 0 del; 3 mod; 5196 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/fs/zfs/edonr_zfs.c

4185 New hash algorithm support
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sha256.c

4185 New hash algorithm support
32 lines changed: 31 ins; 0 del; 1 mod; 49 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/fs/zfs/skein_zfs.c

4185 New hash algorithm support
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c

4185 New hash algorithm support
29 lines changed: 29 ins; 0 del; 0 mod; 6523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_misc.c

4185 New hash algorithm support
63 lines changed: 62 ins; 0 del; 1 mod; 1860 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/dmu.h

4185 New hash algorithm support
2 lines changed: 2 ins; 0 del; 0 mod; 813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa.h

4185 New hash algorithm support
13 lines changed: 13 ins; 0 del; 0 mod; 703 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/spa_impl.h

4185 New hash algorithm support
6 lines changed: 6 ins; 0 del; 0 mod; 272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zio.h

4185 New hash algorithm support
3 lines changed: 3 ins; 0 del; 0 mod; 587 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/sys/zio_checksum.h

4185 New hash algorithm support
26 lines changed: 23 ins; 0 del; 3 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ioctl.c

4185 New hash algorithm support
85 lines changed: 80 ins; 5 del; 0 mod; 5923 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zio_checksum.c

4185 New hash algorithm support
113 lines changed: 97 ins; 0 del; 16 mod; 261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

4185 New hash algorithm support
3 lines changed: 3 ins; 0 del; 0 mod; 1386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/crypto/common.h

4185 New hash algorithm support
5 lines changed: 5 ins; 0 del; 0 mod; 593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/debug.h

4185 New hash algorithm support
9 lines changed: 9 ins; 0 del; 0 mod; 154 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/edonr.h

4185 New hash algorithm support
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sha2.h

4185 New hash algorithm support
10 lines changed: 9 ins; 0 del; 1 mod; 141 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/skein.h

4185 New hash algorithm support
178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel.shared

4185 New hash algorithm support
2 lines changed: 2 ins; 0 del; 0 mod; 753 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/edonr/Makefile

4185 New hash algorithm support
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/skein/Makefile

4185 New hash algorithm support
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/zfs/Makefile

4185 New hash algorithm support
5 lines changed: 4 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/Makefile.sparc.shared

4185 New hash algorithm support
4 lines changed: 3 ins; 1 del; 0 mod; 518 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/sparc/edonr/Makefile

4185 New hash algorithm support
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/sparc/skein/Makefile

4185 New hash algorithm support
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/zfs/Makefile

4185 New hash algorithm support
4 lines changed: 3 ins; 0 del; 1 mod; 119 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.