Code Review for illumos-gate

Prepared by:Super-User (root) on 2015-Apr-30 20:52 +0200 CEST
Workspace:/code/illumos-gate (at ede842188b49)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 3bb0cb708b0d)
Summary of changes: 3021 lines changed: 2323 ins; 417 del; 281 mod; 13449 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_impl.c

4896 Performance improvements for KCF AES modes
357 lines changed: 277 ins; 62 del; 18 mod; 1710 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_impl.h

4896 Performance improvements for KCF AES modes
85 lines changed: 77 ins; 4 del; 4 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_modes.c

4896 Performance improvements for KCF AES modes
148 lines changed: 83 ins; 17 del; 48 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/amd64/aes_intel.s

4896 Performance improvements for KCF AES modes
734 lines changed: 634 ins; 81 del; 19 mod; 754 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/blowfish/blowfish_impl.c

4896 Performance improvements for KCF AES modes
9 lines changed: 3 ins; 0 del; 6 mod; 766 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/blowfish/blowfish_impl.h

4896 Performance improvements for KCF AES modes
7 lines changed: 3 ins; 2 del; 2 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/des/des_impl.c

4896 Performance improvements for KCF AES modes
13 lines changed: 3 ins; 0 del; 10 mod; 1101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/des/des_impl.h

4896 Performance improvements for KCF AES modes
5 lines changed: 3 ins; 0 del; 2 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/amd64/gcm_intel.s

4896 Performance improvements for KCF AES modes
167 lines changed: 92 ins; 72 del; 3 mod; 262 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/modes/amd64/gcm_intel_cryptogams.s

4896 Performance improvements for KCF AES modes
512 lines changed: 512 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/cbc.c

4896 Performance improvements for KCF AES modes
90 lines changed: 85 ins; 0 del; 5 mod; 315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/ccm.c

4896 Performance improvements for KCF AES modes
11 lines changed: 2 ins; 0 del; 9 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/ctr.c

4896 Performance improvements for KCF AES modes
29 lines changed: 27 ins; 0 del; 2 mod; 247 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/ecb.c

4896 Performance improvements for KCF AES modes
35 lines changed: 34 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/gcm.c

4896 Performance improvements for KCF AES modes
472 lines changed: 320 ins; 66 del; 86 mod; 602 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/modes.c

4896 Performance improvements for KCF AES modes
96 lines changed: 3 ins; 93 del; 0 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/modes/modes.h

4896 Performance improvements for KCF AES modes
186 lines changed: 145 ins; 13 del; 28 mod; 352 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/libsoftcrypto/amd64/Makefile

4896 Performance improvements for KCF AES modes
2 lines changed: 2 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/libsoftcrypto/i386/Makefile

4896 Performance improvements for KCF AES modes
2 lines changed: 2 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/core/kcf_prov_lib.c

4896 Performance improvements for KCF AES modes
6 lines changed: 3 ins; 0 del; 3 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/io/aes.c

4896 Performance improvements for KCF AES modes
41 lines changed: 5 ins; 7 del; 29 mod; 1436 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/io/blowfish.c

4896 Performance improvements for KCF AES modes
4 lines changed: 3 ins; 0 del; 1 mod; 869 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/des/des_crypt.c

4896 Performance improvements for KCF AES modes
4 lines changed: 3 ins; 0 del; 1 mod; 1159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/crypto/impl.h

4896 Performance improvements for KCF AES modes
4 lines changed: 1 ins; 0 del; 3 mod; 1407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/kcf/Makefile

4896 Performance improvements for KCF AES modes
2 lines changed: 1 ins; 0 del; 1 mod; 107 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.