Code Review for il_5218

Prepared by: (richard) on 2014-Dec-14 23:31 +0100 CET
Workspace:/home/richard/ws/illumos-gate (at 21278495ff9c)
Compare against: HEAD^ (at 0afb49ca75ee)
Summary of changes: 185 lines changed: 62 ins; 21 del; 102 mod; 48867 unchg
Patch of changes: il_5218.patch
Printable review: il_5218.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/avs/sdbc/scmadm.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 2155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bart/compare.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 653 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/getprm.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 249 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/gio.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/interface.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
3 lines changed: 0 ins; 0 del; 3 mod; 480 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/sysfiles.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 774 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/uudecode.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 539 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/chmod/chmod.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 1469 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/tpmadm/admin_cmds.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
3 lines changed: 0 ins; 0 del; 3 mod; 708 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipsecutils/ikeadm.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
4 lines changed: 0 ins; 0 del; 4 mod; 3467 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/fabric-xlate/fx_fabric.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
11 lines changed: 0 ins; 0 del; 11 mod; 847 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/lp/cmd/lpsched/fncs.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 993 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/lvm/rpc.mdcommd/mdmn_commd_server.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 3229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_termio.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 1976 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/sysevent.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
4 lines changed: 0 ins; 0 del; 4 mod; 495 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/usba/usb.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
8 lines changed: 0 ins; 0 del; 8 mod; 795 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/picl/plugins/common/piclevent/picl_slm.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
3 lines changed: 0 ins; 0 del; 3 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/powertop/common/powertop.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
2 lines changed: 0 ins; 0 del; 2 mod; 419 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/powertop/common/suggestions.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/svcs/svcs.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
4 lines changed: 0 ins; 0 del; 4 mod; 3924 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/syseventd/modules/devfsadmd_mod/devfsadmd_mod.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 364 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/syseventd/modules/sysevent_reg_mod/sysevent_reg_mod.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tar/tar.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
11 lines changed: 0 ins; 0 del; 11 mod; 9465 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tnf/tnfxtract/tnfxtract.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/stddef_iso.h

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
15 lines changed: 5 ins; 10 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/unistd.h

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
13 lines changed: 5 ins; 8 del; 0 mod; 716 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/cfgadm_plugins/pci/common/cfga.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
3 lines changed: 0 ins; 0 del; 3 mod; 1863 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/cfgadm_plugins/shp/common/shp.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 1703 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/i86pc/chip/chip_intel.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
4 lines changed: 0 ins; 0 del; 4 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/gss_mechs/mech_krb5/crypto/des/afsstring2key.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 599 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/gss_mechs/mech_krb5/krb5/krb/vfy_increds.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
9 lines changed: 0 ins; 0 del; 9 mod; 242 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/getopt.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 308 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_handle.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 480 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libscf/common/midlevel.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 3150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtnfctl/elf.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 243 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libumem/common/misc.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 0 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 1 ins; 0 del; 0 mod; 2134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/gssapi/mechs/krb5/crypto/cksumtypes.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
9 lines changed: 0 ins; 0 del; 9 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/gssapi/mechs/krb5/crypto/etypes.c

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
6 lines changed: 0 ins; 3 del; 3 mod; 434 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
1 line changed: 1 ins; 0 del; 0 mod; 1377 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/null.h

5218 posix definition of NULL
correct unistd.h and iso/stddef_iso.h
update gate source affected
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/richard/ws/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.