1 /******************************************************************************
   2  *
   3  * Module Name: exprep - ACPI AML (p-code) execution - field prep utilities
   4  *
   5  *****************************************************************************/
   6 
   7 /*
   8  * Copyright (C) 2000 - 2014, Intel Corp.
   9  * All rights reserved.
  10  *
  11  * Redistribution and use in source and binary forms, with or without
  12  * modification, are permitted provided that the following conditions
  13  * are met:
  14  * 1. Redistributions of source code must retain the above copyright
  15  *    notice, this list of conditions, and the following disclaimer,
  16  *    without modification.
  17  * 2. Redistributions in binary form must reproduce at minimum a disclaimer
  18  *    substantially similar to the "NO WARRANTY" disclaimer below
  19  *    ("Disclaimer") and any redistribution must be conditioned upon
  20  *    including a substantially similar Disclaimer requirement for further
  21  *    binary redistribution.
  22  * 3. Neither the names of the above-listed copyright holders nor the names
  23  *    of any contributors may be used to endorse or promote products derived
  24  *    from this software without specific prior written permission.
  25  *
  26  * Alternatively, this software may be distributed under the terms of the
  27  * GNU General Public License ("GPL") version 2 as published by the Free
  28  * Software Foundation.
  29  *
  30  * NO WARRANTY
  31  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  32  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  33  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR
  34  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  35  * HOLDERS OR CONTRIBUTORS BE LIABLE FOR SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  36  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
  37  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  38  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  39  * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
  40  * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  41  * POSSIBILITY OF SUCH DAMAGES.
  42  */
  43 
  44 #define __EXPREP_C__
  45 
  46 #include "acpi.h"
  47 #include "accommon.h"
  48 #include "acinterp.h"
  49 #include "amlcode.h"
  50 #include "acnamesp.h"
  51 #include "acdispat.h"
  52 
  53 
  54 #define _COMPONENT          ACPI_EXECUTER
  55         ACPI_MODULE_NAME    ("exprep")
  56 
  57 /* Local prototypes */
  58 
  59 static UINT32
  60 AcpiExDecodeFieldAccess (
  61     ACPI_OPERAND_OBJECT     *ObjDesc,
  62     UINT8                   FieldFlags,
  63     UINT32                  *ReturnByteAlignment);
  64 
  65 
  66 #ifdef ACPI_UNDER_DEVELOPMENT
  67 
  68 static UINT32
  69 AcpiExGenerateAccess (
  70     UINT32                  FieldBitOffset,
  71     UINT32                  FieldBitLength,
  72     UINT32                  RegionLength);
  73 
  74 /*******************************************************************************
  75  *
  76  * FUNCTION:    AcpiExGenerateAccess
  77  *
  78  * PARAMETERS:  FieldBitOffset      - Start of field within parent region/buffer
  79  *              FieldBitLength      - Length of field in bits
  80  *              RegionLength        - Length of parent in bytes
  81  *
  82  * RETURN:      Field granularity (8, 16, 32 or 64) and
  83  *              ByteAlignment (1, 2, 3, or 4)
  84  *
  85  * DESCRIPTION: Generate an optimal access width for fields defined with the
  86  *              AnyAcc keyword.
  87  *
  88  * NOTE: Need to have the RegionLength in order to check for boundary
  89  *       conditions (end-of-region). However, the RegionLength is a deferred
  90  *       operation. Therefore, to complete this implementation, the generation
  91  *       of this access width must be deferred until the region length has
  92  *       been evaluated.
  93  *
  94  ******************************************************************************/
  95 
  96 static UINT32
  97 AcpiExGenerateAccess (
  98     UINT32                  FieldBitOffset,
  99     UINT32                  FieldBitLength,
 100     UINT32                  RegionLength)
 101 {
 102     UINT32                  FieldByteLength;
 103     UINT32                  FieldByteOffset;
 104     UINT32                  FieldByteEndOffset;
 105     UINT32                  AccessByteWidth;
 106     UINT32                  FieldStartOffset;
 107     UINT32                  FieldEndOffset;
 108     UINT32                  MinimumAccessWidth = 0xFFFFFFFF;
 109     UINT32                  MinimumAccesses = 0xFFFFFFFF;
 110     UINT32                  Accesses;
 111 
 112 
 113     ACPI_FUNCTION_TRACE (ExGenerateAccess);
 114 
 115 
 116     /* Round Field start offset and length to "minimal" byte boundaries */
 117 
 118     FieldByteOffset    = ACPI_DIV_8 (ACPI_ROUND_DOWN (FieldBitOffset, 8));
 119     FieldByteEndOffset = ACPI_DIV_8 (ACPI_ROUND_UP   (FieldBitLength +
 120                                                       FieldBitOffset, 8));
 121     FieldByteLength    = FieldByteEndOffset - FieldByteOffset;
 122 
 123     ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 124         "Bit length %u, Bit offset %u\n",
 125         FieldBitLength, FieldBitOffset));
 126 
 127     ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 128         "Byte Length %u, Byte Offset %u, End Offset %u\n",
 129         FieldByteLength, FieldByteOffset, FieldByteEndOffset));
 130 
 131     /*
 132      * Iterative search for the maximum access width that is both aligned
 133      * and does not go beyond the end of the region
 134      *
 135      * Start at ByteAcc and work upwards to QwordAcc max. (1,2,4,8 bytes)
 136      */
 137     for (AccessByteWidth = 1; AccessByteWidth <= 8; AccessByteWidth <<= 1)
 138     {
 139         /*
 140          * 1) Round end offset up to next access boundary and make sure that
 141          *    this does not go beyond the end of the parent region.
 142          * 2) When the Access width is greater than the FieldByteLength, we
 143          *    are done. (This does not optimize for the perfectly aligned
 144          *    case yet).
 145          */
 146         if (ACPI_ROUND_UP (FieldByteEndOffset, AccessByteWidth) <= RegionLength)
 147         {
 148             FieldStartOffset =
 149                 ACPI_ROUND_DOWN (FieldByteOffset, AccessByteWidth) /
 150                 AccessByteWidth;
 151 
 152             FieldEndOffset =
 153                 ACPI_ROUND_UP ((FieldByteLength + FieldByteOffset),
 154                     AccessByteWidth) / AccessByteWidth;
 155 
 156             Accesses = FieldEndOffset - FieldStartOffset;
 157 
 158             ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 159                 "AccessWidth %u end is within region\n", AccessByteWidth));
 160 
 161             ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 162                 "Field Start %u, Field End %u -- requires %u accesses\n",
 163                 FieldStartOffset, FieldEndOffset, Accesses));
 164 
 165             /* Single access is optimal */
 166 
 167             if (Accesses <= 1)
 168             {
 169                 ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 170                     "Entire field can be accessed with one operation of size %u\n",
 171                     AccessByteWidth));
 172                 return_VALUE (AccessByteWidth);
 173             }
 174 
 175             /*
 176              * Fits in the region, but requires more than one read/write.
 177              * try the next wider access on next iteration
 178              */
 179             if (Accesses < MinimumAccesses)
 180             {
 181                 MinimumAccesses    = Accesses;
 182                 MinimumAccessWidth = AccessByteWidth;
 183             }
 184         }
 185         else
 186         {
 187             ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 188                 "AccessWidth %u end is NOT within region\n", AccessByteWidth));
 189             if (AccessByteWidth == 1)
 190             {
 191                 ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 192                     "Field goes beyond end-of-region!\n"));
 193 
 194                 /* Field does not fit in the region at all */
 195 
 196                 return_VALUE (0);
 197             }
 198 
 199             /*
 200              * This width goes beyond the end-of-region, back off to
 201              * previous access
 202              */
 203             ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 204                 "Backing off to previous optimal access width of %u\n",
 205                 MinimumAccessWidth));
 206             return_VALUE (MinimumAccessWidth);
 207         }
 208     }
 209 
 210     /*
 211      * Could not read/write field with one operation,
 212      * just use max access width
 213      */
 214     ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 215         "Cannot access field in one operation, using width 8\n"));
 216     return_VALUE (8);
 217 }
 218 #endif /* ACPI_UNDER_DEVELOPMENT */
 219 
 220 
 221 /*******************************************************************************
 222  *
 223  * FUNCTION:    AcpiExDecodeFieldAccess
 224  *
 225  * PARAMETERS:  ObjDesc             - Field object
 226  *              FieldFlags          - Encoded fieldflags (contains access bits)
 227  *              ReturnByteAlignment - Where the byte alignment is returned
 228  *
 229  * RETURN:      Field granularity (8, 16, 32 or 64) and
 230  *              ByteAlignment (1, 2, 3, or 4)
 231  *
 232  * DESCRIPTION: Decode the AccessType bits of a field definition.
 233  *
 234  ******************************************************************************/
 235 
 236 static UINT32
 237 AcpiExDecodeFieldAccess (
 238     ACPI_OPERAND_OBJECT     *ObjDesc,
 239     UINT8                   FieldFlags,
 240     UINT32                  *ReturnByteAlignment)
 241 {
 242     UINT32                  Access;
 243     UINT32                  ByteAlignment;
 244     UINT32                  BitLength;
 245 
 246 
 247     ACPI_FUNCTION_TRACE (ExDecodeFieldAccess);
 248 
 249 
 250     Access = (FieldFlags & AML_FIELD_ACCESS_TYPE_MASK);
 251 
 252     switch (Access)
 253     {
 254     case AML_FIELD_ACCESS_ANY:
 255 
 256 #ifdef ACPI_UNDER_DEVELOPMENT
 257         ByteAlignment =
 258             AcpiExGenerateAccess (ObjDesc->CommonField.StartFieldBitOffset,
 259                 ObjDesc->CommonField.BitLength,
 260                 0xFFFFFFFF /* Temp until we pass RegionLength as parameter */);
 261         BitLength = ByteAlignment * 8;
 262 #endif
 263 
 264         ByteAlignment = 1;
 265         BitLength = 8;
 266         break;
 267 
 268     case AML_FIELD_ACCESS_BYTE:
 269     case AML_FIELD_ACCESS_BUFFER:   /* ACPI 2.0 (SMBus Buffer) */
 270 
 271         ByteAlignment = 1;
 272         BitLength     = 8;
 273         break;
 274 
 275     case AML_FIELD_ACCESS_WORD:
 276 
 277         ByteAlignment = 2;
 278         BitLength     = 16;
 279         break;
 280 
 281     case AML_FIELD_ACCESS_DWORD:
 282 
 283         ByteAlignment = 4;
 284         BitLength     = 32;
 285         break;
 286 
 287     case AML_FIELD_ACCESS_QWORD:    /* ACPI 2.0 */
 288 
 289         ByteAlignment = 8;
 290         BitLength     = 64;
 291         break;
 292 
 293     default:
 294 
 295         /* Invalid field access type */
 296 
 297         ACPI_ERROR ((AE_INFO,
 298             "Unknown field access type 0x%X",
 299             Access));
 300         return_UINT32 (0);
 301     }
 302 
 303     if (ObjDesc->Common.Type == ACPI_TYPE_BUFFER_FIELD)
 304     {
 305         /*
 306          * BufferField access can be on any byte boundary, so the
 307          * ByteAlignment is always 1 byte -- regardless of any ByteAlignment
 308          * implied by the field access type.
 309          */
 310         ByteAlignment = 1;
 311     }
 312 
 313     *ReturnByteAlignment = ByteAlignment;
 314     return_UINT32 (BitLength);
 315 }
 316 
 317 
 318 /*******************************************************************************
 319  *
 320  * FUNCTION:    AcpiExPrepCommonFieldObject
 321  *
 322  * PARAMETERS:  ObjDesc             - The field object
 323  *              FieldFlags          - Access, LockRule, and UpdateRule.
 324  *                                    The format of a FieldFlag is described
 325  *                                    in the ACPI specification
 326  *              FieldAttribute      - Special attributes (not used)
 327  *              FieldBitPosition    - Field start position
 328  *              FieldBitLength      - Field length in number of bits
 329  *
 330  * RETURN:      Status
 331  *
 332  * DESCRIPTION: Initialize the areas of the field object that are common
 333  *              to the various types of fields. Note: This is very "sensitive"
 334  *              code because we are solving the general case for field
 335  *              alignment.
 336  *
 337  ******************************************************************************/
 338 
 339 ACPI_STATUS
 340 AcpiExPrepCommonFieldObject (
 341     ACPI_OPERAND_OBJECT     *ObjDesc,
 342     UINT8                   FieldFlags,
 343     UINT8                   FieldAttribute,
 344     UINT32                  FieldBitPosition,
 345     UINT32                  FieldBitLength)
 346 {
 347     UINT32                  AccessBitWidth;
 348     UINT32                  ByteAlignment;
 349     UINT32                  NearestByteAddress;
 350 
 351 
 352     ACPI_FUNCTION_TRACE (ExPrepCommonFieldObject);
 353 
 354 
 355     /*
 356      * Note: the structure being initialized is the
 357      * ACPI_COMMON_FIELD_INFO;  No structure fields outside of the common
 358      * area are initialized by this procedure.
 359      */
 360     ObjDesc->CommonField.FieldFlags = FieldFlags;
 361     ObjDesc->CommonField.Attribute  = FieldAttribute;
 362     ObjDesc->CommonField.BitLength  = FieldBitLength;
 363 
 364     /*
 365      * Decode the access type so we can compute offsets. The access type gives
 366      * two pieces of information - the width of each field access and the
 367      * necessary ByteAlignment (address granularity) of the access.
 368      *
 369      * For AnyAcc, the AccessBitWidth is the largest width that is both
 370      * necessary and possible in an attempt to access the whole field in one
 371      * I/O operation. However, for AnyAcc, the ByteAlignment is always one
 372      * byte.
 373      *
 374      * For all Buffer Fields, the ByteAlignment is always one byte.
 375      *
 376      * For all other access types (Byte, Word, Dword, Qword), the Bitwidth is
 377      * the same (equivalent) as the ByteAlignment.
 378      */
 379     AccessBitWidth = AcpiExDecodeFieldAccess (ObjDesc, FieldFlags,
 380                         &ByteAlignment);
 381     if (!AccessBitWidth)
 382     {
 383         return_ACPI_STATUS (AE_AML_OPERAND_VALUE);
 384     }
 385 
 386     /* Setup width (access granularity) fields (values are: 1, 2, 4, 8) */
 387 
 388     ObjDesc->CommonField.AccessByteWidth = (UINT8)
 389         ACPI_DIV_8 (AccessBitWidth);
 390 
 391     /*
 392      * BaseByteOffset is the address of the start of the field within the
 393      * region. It is the byte address of the first *datum* (field-width data
 394      * unit) of the field. (i.e., the first datum that contains at least the
 395      * first *bit* of the field.)
 396      *
 397      * Note: ByteAlignment is always either equal to the AccessBitWidth or 8
 398      * (Byte access), and it defines the addressing granularity of the parent
 399      * region or buffer.
 400      */
 401     NearestByteAddress =
 402         ACPI_ROUND_BITS_DOWN_TO_BYTES (FieldBitPosition);
 403     ObjDesc->CommonField.BaseByteOffset = (UINT32)
 404         ACPI_ROUND_DOWN (NearestByteAddress, ByteAlignment);
 405 
 406     /*
 407      * StartFieldBitOffset is the offset of the first bit of the field within
 408      * a field datum.
 409      */
 410     ObjDesc->CommonField.StartFieldBitOffset = (UINT8)
 411         (FieldBitPosition - ACPI_MUL_8 (ObjDesc->CommonField.BaseByteOffset));
 412 
 413     return_ACPI_STATUS (AE_OK);
 414 }
 415 
 416 
 417 /*******************************************************************************
 418  *
 419  * FUNCTION:    AcpiExPrepFieldValue
 420  *
 421  * PARAMETERS:  Info    - Contains all field creation info
 422  *
 423  * RETURN:      Status
 424  *
 425  * DESCRIPTION: Construct an object of type ACPI_OPERAND_OBJECT with a
 426  *              subtype of DefField and connect it to the parent Node.
 427  *
 428  ******************************************************************************/
 429 
 430 ACPI_STATUS
 431 AcpiExPrepFieldValue (
 432     ACPI_CREATE_FIELD_INFO  *Info)
 433 {
 434     ACPI_OPERAND_OBJECT     *ObjDesc;
 435     ACPI_OPERAND_OBJECT     *SecondDesc = NULL;
 436     ACPI_STATUS             Status;
 437     UINT32                  AccessByteWidth;
 438     UINT32                  Type;
 439 
 440 
 441     ACPI_FUNCTION_TRACE (ExPrepFieldValue);
 442 
 443 
 444     /* Parameter validation */
 445 
 446     if (Info->FieldType != ACPI_TYPE_LOCAL_INDEX_FIELD)
 447     {
 448         if (!Info->RegionNode)
 449         {
 450             ACPI_ERROR ((AE_INFO, "Null RegionNode"));
 451             return_ACPI_STATUS (AE_AML_NO_OPERAND);
 452         }
 453 
 454         Type = AcpiNsGetType (Info->RegionNode);
 455         if (Type != ACPI_TYPE_REGION)
 456         {
 457             ACPI_ERROR ((AE_INFO, "Needed Region, found type 0x%X (%s)",
 458                 Type, AcpiUtGetTypeName (Type)));
 459 
 460             return_ACPI_STATUS (AE_AML_OPERAND_TYPE);
 461         }
 462     }
 463 
 464     /* Allocate a new field object */
 465 
 466     ObjDesc = AcpiUtCreateInternalObject (Info->FieldType);
 467     if (!ObjDesc)
 468     {
 469         return_ACPI_STATUS (AE_NO_MEMORY);
 470     }
 471 
 472     /* Initialize areas of the object that are common to all fields */
 473 
 474     ObjDesc->CommonField.Node = Info->FieldNode;
 475     Status = AcpiExPrepCommonFieldObject (ObjDesc,
 476                 Info->FieldFlags, Info->Attribute,
 477                 Info->FieldBitPosition, Info->FieldBitLength);
 478     if (ACPI_FAILURE (Status))
 479     {
 480         AcpiUtDeleteObjectDesc (ObjDesc);
 481         return_ACPI_STATUS (Status);
 482     }
 483 
 484     /* Initialize areas of the object that are specific to the field type */
 485 
 486     switch (Info->FieldType)
 487     {
 488     case ACPI_TYPE_LOCAL_REGION_FIELD:
 489 
 490         ObjDesc->Field.RegionObj = AcpiNsGetAttachedObject (Info->RegionNode);
 491 
 492         /* Fields specific to GenericSerialBus fields */
 493 
 494         ObjDesc->Field.AccessLength = Info->AccessLength;
 495 
 496         if (Info->ConnectionNode)
 497         {
 498             SecondDesc = Info->ConnectionNode->Object;
 499             if (!(SecondDesc->Common.Flags & AOPOBJ_DATA_VALID))
 500             {
 501                 Status = AcpiDsGetBufferArguments (SecondDesc);
 502                 if (ACPI_FAILURE (Status))
 503                 {
 504                     AcpiUtDeleteObjectDesc (ObjDesc);
 505                     return_ACPI_STATUS (Status);
 506                 }
 507             }
 508 
 509             ObjDesc->Field.ResourceBuffer = SecondDesc->Buffer.Pointer;
 510             ObjDesc->Field.ResourceLength = (UINT16) SecondDesc->Buffer.Length;
 511         }
 512         else if (Info->ResourceBuffer)
 513         {
 514             ObjDesc->Field.ResourceBuffer = Info->ResourceBuffer;
 515             ObjDesc->Field.ResourceLength = Info->ResourceLength;
 516         }
 517 
 518         /* Allow full data read from EC address space */
 519 
 520         if ((ObjDesc->Field.RegionObj->Region.SpaceId == ACPI_ADR_SPACE_EC) &&
 521             (ObjDesc->CommonField.BitLength > 8))
 522         {
 523             AccessByteWidth = ACPI_ROUND_BITS_UP_TO_BYTES (
 524                 ObjDesc->CommonField.BitLength);
 525 
 526             /* Maximum byte width supported is 255 */
 527 
 528             if (AccessByteWidth < 256)
 529             {
 530                 ObjDesc->CommonField.AccessByteWidth = (UINT8) AccessByteWidth;
 531             }
 532         }
 533 
 534         /* An additional reference for the container */
 535 
 536         AcpiUtAddReference (ObjDesc->Field.RegionObj);
 537 
 538         ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 539             "RegionField: BitOff %X, Off %X, Gran %X, Region %p\n",
 540             ObjDesc->Field.StartFieldBitOffset, ObjDesc->Field.BaseByteOffset,
 541             ObjDesc->Field.AccessByteWidth, ObjDesc->Field.RegionObj));
 542         break;
 543 
 544     case ACPI_TYPE_LOCAL_BANK_FIELD:
 545 
 546         ObjDesc->BankField.Value = Info->BankValue;
 547         ObjDesc->BankField.RegionObj =
 548             AcpiNsGetAttachedObject (Info->RegionNode);
 549         ObjDesc->BankField.BankObj =
 550             AcpiNsGetAttachedObject (Info->RegisterNode);
 551 
 552         /* An additional reference for the attached objects */
 553 
 554         AcpiUtAddReference (ObjDesc->BankField.RegionObj);
 555         AcpiUtAddReference (ObjDesc->BankField.BankObj);
 556 
 557         ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 558             "Bank Field: BitOff %X, Off %X, Gran %X, Region %p, BankReg %p\n",
 559             ObjDesc->BankField.StartFieldBitOffset,
 560             ObjDesc->BankField.BaseByteOffset,
 561             ObjDesc->Field.AccessByteWidth,
 562             ObjDesc->BankField.RegionObj,
 563             ObjDesc->BankField.BankObj));
 564 
 565         /*
 566          * Remember location in AML stream of the field unit
 567          * opcode and operands -- since the BankValue
 568          * operands must be evaluated.
 569          */
 570         SecondDesc = ObjDesc->Common.NextObject;
 571         SecondDesc->Extra.AmlStart = ACPI_CAST_PTR (ACPI_PARSE_OBJECT,
 572             Info->DataRegisterNode)->Named.Data;
 573         SecondDesc->Extra.AmlLength = ACPI_CAST_PTR (ACPI_PARSE_OBJECT,
 574             Info->DataRegisterNode)->Named.Length;
 575 
 576         break;
 577 
 578     case ACPI_TYPE_LOCAL_INDEX_FIELD:
 579 
 580         /* Get the Index and Data registers */
 581 
 582         ObjDesc->IndexField.IndexObj =
 583             AcpiNsGetAttachedObject (Info->RegisterNode);
 584         ObjDesc->IndexField.DataObj =
 585             AcpiNsGetAttachedObject (Info->DataRegisterNode);
 586 
 587         if (!ObjDesc->IndexField.DataObj || !ObjDesc->IndexField.IndexObj)
 588         {
 589             ACPI_ERROR ((AE_INFO, "Null Index Object during field prep"));
 590             AcpiUtDeleteObjectDesc (ObjDesc);
 591             return_ACPI_STATUS (AE_AML_INTERNAL);
 592         }
 593 
 594         /* An additional reference for the attached objects */
 595 
 596         AcpiUtAddReference (ObjDesc->IndexField.DataObj);
 597         AcpiUtAddReference (ObjDesc->IndexField.IndexObj);
 598 
 599         /*
 600          * April 2006: Changed to match MS behavior
 601          *
 602          * The value written to the Index register is the byte offset of the
 603          * target field in units of the granularity of the IndexField
 604          *
 605          * Previously, the value was calculated as an index in terms of the
 606          * width of the Data register, as below:
 607          *
 608          *      ObjDesc->IndexField.Value = (UINT32)
 609          *          (Info->FieldBitPosition / ACPI_MUL_8 (
 610          *              ObjDesc->Field.AccessByteWidth));
 611          *
 612          * February 2006: Tried value as a byte offset:
 613          *      ObjDesc->IndexField.Value = (UINT32)
 614          *          ACPI_DIV_8 (Info->FieldBitPosition);
 615          */
 616         ObjDesc->IndexField.Value = (UINT32) ACPI_ROUND_DOWN (
 617             ACPI_DIV_8 (Info->FieldBitPosition),
 618             ObjDesc->IndexField.AccessByteWidth);
 619 
 620         ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
 621             "IndexField: BitOff %X, Off %X, Value %X, Gran %X, Index %p, Data %p\n",
 622             ObjDesc->IndexField.StartFieldBitOffset,
 623             ObjDesc->IndexField.BaseByteOffset,
 624             ObjDesc->IndexField.Value,
 625             ObjDesc->Field.AccessByteWidth,
 626             ObjDesc->IndexField.IndexObj,
 627             ObjDesc->IndexField.DataObj));
 628         break;
 629 
 630     default:
 631 
 632         /* No other types should get here */
 633 
 634         break;
 635     }
 636 
 637     /*
 638      * Store the constructed descriptor (ObjDesc) into the parent Node,
 639      * preserving the current type of that NamedObj.
 640      */
 641     Status = AcpiNsAttachObject (Info->FieldNode, ObjDesc,
 642                 AcpiNsGetType (Info->FieldNode));
 643 
 644     ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD, "Set NamedObj %p [%4.4s], ObjDesc %p\n",
 645         Info->FieldNode, AcpiUtGetNodeName (Info->FieldNode), ObjDesc));
 646 
 647     /* Remove local reference to the object */
 648 
 649     AcpiUtRemoveReference (ObjDesc);
 650     return_ACPI_STATUS (Status);
 651 }