Code Review for illumos-sfxge-webrev

Prepared by:Super-User (root) on 2013-Aug-22 18:59 -0400 EDT
Workspace:/codepool/illumos-sfxge-webrev (at a27a6b7b4e91)
Compare against: origin/master (http://github.com/illumos/illumos-gate.git at b62969f868a8)
Summary of changes: 62954 lines changed: 62954 ins; 0 del; 0 mod; 5509 unchg
Patch of changes: illumos-sfxge-webrev.patch
Printable review: illumos-sfxge-webrev.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/driver-network-sfxge.mf

Merged sfxge driver
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

Merged sfxge driver
12 lines changed: 12 ins; 0 del; 0 mod; 2042 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules

Merged sfxge driver
7 lines changed: 7 ins; 0 del; 0 mod; 2717 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/compat.h

Merged sfxge driver
22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efsys.h

Merged sfxge driver
691 lines changed: 691 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx.h

Merged sfxge driver
1906 lines changed: 1906 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_bootcfg.c

Merged sfxge driver
342 lines changed: 342 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_ev.c

Merged sfxge driver
1120 lines changed: 1120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_impl.h

Merged sfxge driver
745 lines changed: 745 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_intr.c

Merged sfxge driver
354 lines changed: 354 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_mac.c

Merged sfxge driver
684 lines changed: 684 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_mcdi.c

Merged sfxge driver
740 lines changed: 740 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_mcdi.h

Merged sfxge driver
241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_mon.c

Merged sfxge driver
271 lines changed: 271 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_nic.c

Merged sfxge driver
678 lines changed: 678 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_nvram.c

Merged sfxge driver
372 lines changed: 372 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_phy.c

Merged sfxge driver
765 lines changed: 765 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_port.c

Merged sfxge driver
226 lines changed: 226 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_regs.h

Merged sfxge driver
3865 lines changed: 3865 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_regs_mcdi.h

Merged sfxge driver
3054 lines changed: 3054 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_regs_pci.h

Merged sfxge driver
2376 lines changed: 2376 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_rx.c

Merged sfxge driver
817 lines changed: 817 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_sram.c

Merged sfxge driver
294 lines changed: 294 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_tx.c

Merged sfxge driver
481 lines changed: 481 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_types.h

Merged sfxge driver
1605 lines changed: 1605 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_vpd.c

Merged sfxge driver
999 lines changed: 999 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/efx_wol.c

Merged sfxge driver
396 lines changed: 396 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_gmac.c

Merged sfxge driver
403 lines changed: 403 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_gmac.h

Merged sfxge driver
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_i2c.c

Merged sfxge driver
842 lines changed: 842 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_impl.h

Merged sfxge driver
382 lines changed: 382 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_mac.c

Merged sfxge driver
381 lines changed: 381 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_mdio.c

Merged sfxge driver
214 lines changed: 214 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_nic.c

Merged sfxge driver
1101 lines changed: 1101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_nvram.c

Merged sfxge driver
841 lines changed: 841 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_nvram.h

Merged sfxge driver
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_spi.c

Merged sfxge driver
433 lines changed: 433 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_sram.c

Merged sfxge driver
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_stats.h

Merged sfxge driver
245 lines changed: 245 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_vpd.c

Merged sfxge driver
301 lines changed: 301 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_xmac.c

Merged sfxge driver
537 lines changed: 537 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/falcon_xmac.h

Merged sfxge driver
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/lm87.c

Merged sfxge driver
232 lines changed: 232 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/lm87.h

Merged sfxge driver
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/lm87_impl.h

Merged sfxge driver
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/max6647.c

Merged sfxge driver
192 lines changed: 192 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/max6647.h

Merged sfxge driver
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/max6647_impl.h

Merged sfxge driver
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/nullmon.c

Merged sfxge driver
68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/nullmon.h

Merged sfxge driver
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/nullphy.c

Merged sfxge driver
191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/nullphy.h

Merged sfxge driver
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/nullphy_impl.h

Merged sfxge driver
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2022c2.c

Merged sfxge driver
566 lines changed: 566 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2022c2.h

Merged sfxge driver
150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2022c2_impl.h

Merged sfxge driver
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2025c.c

Merged sfxge driver
1117 lines changed: 1117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2025c.h

Merged sfxge driver
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/qt2025c_impl.h

Merged sfxge driver
248 lines changed: 248 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sft9001.c

Merged sfxge driver
2083 lines changed: 2083 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sft9001.h

Merged sfxge driver
267 lines changed: 267 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sft9001_impl.h

Merged sfxge driver
236 lines changed: 236 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfx7101.c

Merged sfxge driver
1745 lines changed: 1745 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfx7101.h

Merged sfxge driver
231 lines changed: 231 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfx7101_impl.h

Merged sfxge driver
203 lines changed: 203 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge.c

Merged sfxge driver
1462 lines changed: 1462 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge.conf

Merged sfxge driver
248 lines changed: 248 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge.h

Merged sfxge driver
1085 lines changed: 1085 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_bar.c

Merged sfxge driver
121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_debug.h

Merged sfxge driver
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_dma.c

Merged sfxge driver
180 lines changed: 180 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_err.c

Merged sfxge driver
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_ev.c

Merged sfxge driver
1218 lines changed: 1218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_gld_ndd.c

Merged sfxge driver
1122 lines changed: 1122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_gld_v2.c

Merged sfxge driver
439 lines changed: 439 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_gld_v3.c

Merged sfxge driver
1449 lines changed: 1449 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_intr.c

Merged sfxge driver
826 lines changed: 826 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_ioc.h

Merged sfxge driver
228 lines changed: 228 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_mac.c

Merged sfxge driver
1119 lines changed: 1119 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_mcdi.c

Merged sfxge driver
314 lines changed: 314 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_mon.c

Merged sfxge driver
310 lines changed: 310 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_nvram.c

Merged sfxge driver
193 lines changed: 193 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_pci.c

Merged sfxge driver
232 lines changed: 232 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_phy.c

Merged sfxge driver
626 lines changed: 626 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_rx.c

Merged sfxge driver
2965 lines changed: 2965 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_sram.c

Merged sfxge driver
259 lines changed: 259 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_tcp.c

Merged sfxge driver
142 lines changed: 142 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_tx.c

Merged sfxge driver
3041 lines changed: 3041 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/sfxge_vpd.c

Merged sfxge driver
178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_flash.h

Merged sfxge driver
134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_impl.h

Merged sfxge driver
477 lines changed: 477 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_mac.c

Merged sfxge driver
546 lines changed: 546 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_mon.c

Merged sfxge driver
254 lines changed: 254 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_nic.c

Merged sfxge driver
984 lines changed: 984 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_nvram.c

Merged sfxge driver
996 lines changed: 996 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_phy.c

Merged sfxge driver
857 lines changed: 857 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_sram.c

Merged sfxge driver
173 lines changed: 173 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/siena_vpd.c

Merged sfxge driver
602 lines changed: 602 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/txc43128.c

Merged sfxge driver
1035 lines changed: 1035 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/txc43128.h

Merged sfxge driver
152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/txc43128_impl.h

Merged sfxge driver
172 lines changed: 172 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/version.h

Merged sfxge driver
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/xphy.c

Merged sfxge driver
356 lines changed: 356 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/io/sfxge/xphy.h

Merged sfxge driver
500 lines changed: 500 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel.shared

Merged sfxge driver
1 line changed: 1 ins; 0 del; 0 mod; 750 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/sfxge/Makefile

Merged sfxge driver
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.