Code Review for wr-583b676

Prepared by:Richard Lowe (richlowe) on 2014-Jan-14 16:48 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 583b676d989c)
Compare against: HEAD^ (at 7a4644f96bc1)
Summary of changes: 2298 lines changed: 2259 ins; 4 del; 35 mod; 12746 unchg
Patch of changes: wr-583b676.patch
Printable review: wr-583b676.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggencoding.d 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggencoding.d.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
646 lines changed: 646 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.agghist.d 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.agghist.d.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpack.d 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpack.d.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpackbanner.ksh 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpackbanner.ksh.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpackzoom.d 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggpackzoom.d.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggzoom.d 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dtrace/test/tst/common/aggs/tst.aggzoom.d.out 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_aggregate.c 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
259 lines changed: 252 ins; 2 del; 5 mod; 1931 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_consume.c 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
419 lines changed: 390 ins; 2 del; 27 mod; 2635 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_impl.h 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
12 lines changed: 12 ins; 0 del; 0 mod; 677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_open.c 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
5 lines changed: 3 ins; 0 del; 2 mod; 1421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_options.c 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
22 lines changed: 22 ins; 0 del; 0 mod; 1054 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dtrace.h 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
10 lines changed: 10 ins; 0 del; 0 mod; 590 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-dtrace-tests.mf 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
12 lines changed: 12 ins; 0 del; 0 mod; 2098 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dtrace.h 

4471 DTrace count() with histogram
4472 DTrace full width distribution histograms
4473 DTrace frequency trails
5 lines changed: 4 ins; 0 del; 1 mod; 2340 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.