Code Review for tm_review_rm

Prepared by:Richard Lowe (richlowe) on 2015-Jun-12 18:13 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 8fc3dc8bb828)
Compare against: fb094f2 (at fb094f2caa14)
Summary of changes: 138 lines changed: 9 ins; 124 del; 5 mod; 3346 unchg
Patch of changes: tm_review_rm.patch
Printable review: tm_review_rm.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/Makefile.com

fixup! make: build and install
1 line changed: 0 ins; 1 del; 0 mod; 22 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/main.cc

fixup! make: be serial if 'make', parallel if 'dmake', and parallel if '-j' is specified either way
fixup! make: translate using gettext, rather than the unmaintainable catgets
fixup! make: unifdef for two bugfixes conditioned for unknown reasons (defined)
14 lines changed: 5 ins; 5 del; 4 mod; 3206 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/dosys.h

fixup! make: remove maketool support
1 line changed: 0 ins; 1 del; 0 mod; 37 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/lib/mksh/libmksh.msg (deleted)

fixup! make: translate using gettext, rather than the unmaintainable catgets
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/lib/vroot/libvroot.msg (deleted)

fixup! make: translate using gettext, rather than the unmaintainable catgets
36 lines changed: 0 ins; 36 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1s/Makefile

fixup! make: add the manual page
4 lines changed: 3 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-build-make.mf

fixup! make: add the manual page
1 line changed: 1 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/make/Makefile.com

fixup! tools: build a tools copy of make (which the build will automatically use)
1 line changed: 0 ins; 1 del; 0 mod; 21 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.