Code Review for tm_3_17fc4ee

Prepared by:Richard Lowe (richlowe) on 2015-May-20 11:10 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 17fc4ee3eeb9)
Compare against: HEAD^ (at d2a45cae851d)
Summary of changes: 351 lines changed: 0 ins; 343 del; 8 mod; 32067 unchg
Patch of changes: tm_3_17fc4ee.patch
Printable review: tm_3_17fc4ee.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/ar.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 903 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/default.mk.file

make: remove SCCS ident stuff
2 lines changed: 0 ins; 2 del; 0 mod; 229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/depvar.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/dist.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 576 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/dmake.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/doname.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 3781 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/dosys.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/files.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 728 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/globals.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 212 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/implicit.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 1474 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/macro.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/main.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 3782 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/make.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 24 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/make.rules.file

make: remove SCCS ident stuff
2 lines changed: 0 ins; 2 del; 0 mod; 498 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/misc.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 1002 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/nse.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 605 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/nse_printdep.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/parallel.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 2472 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/pmake.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/read.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 2192 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/read2.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 1933 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/rep.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 524 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/state.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 458 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/make/common/svr4.make.rules.file

make: remove SCCS ident stuff
1 line changed: 0 ins; 1 del; 0 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/avo/avo_alloca.h

make: remove SCCS ident stuff
6 lines changed: 0 ins; 6 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/avo/intl.h

make: remove SCCS ident stuff
6 lines changed: 0 ins; 5 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/bsd/bsd.h

make: remove SCCS ident stuff
6 lines changed: 0 ins; 6 del; 0 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mk/copyright.h

make: remove SCCS ident stuff
3 lines changed: 0 ins; 3 del; 0 mod; 24 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mk/defs.h

make: remove SCCS ident stuff
10 lines changed: 0 ins; 5 del; 5 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksdmsi18n/mksdmsi18n.h

make: remove SCCS ident stuff
6 lines changed: 0 ins; 6 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/defs.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 1037 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/dosys.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/globals.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/i18n.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/libmksh_init.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/macro.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/misc.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/mksh.h

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/read.h

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/vroot/args.h

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/vroot/report.h

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/vroot/vroot.h

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/bsd/src/bsd.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 178 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/makestate/src/ld_file.c

make: remove SCCS ident stuff
6 lines changed: 0 ins; 4 del; 2 mod; 186 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/makestate/src/lock.c

make: remove SCCS ident stuff
3 lines changed: 0 ins; 3 del; 0 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksdmsi18n/src/libmksdmsi18n_init.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/dosys.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 847 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/globals.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/i18n.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/libmksh.msg

make: remove SCCS ident stuff
1 line changed: 0 ins; 1 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/macro.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 1410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/misc.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 1174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/mksh.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/src/read.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/access.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/args.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/chdir.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/chmod.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/chown.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/chroot.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/creat.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/execve.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/libvroot.msg

make: remove SCCS ident stuff
2 lines changed: 0 ins; 2 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/lock.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/lstat.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/mkdir.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/mount.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/open.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/readlink.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/report.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 391 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/rmdir.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/setenv.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/stat.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/statfs.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/truncate.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/unlink.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/unmount.cc

make: remove SCCS ident stuff
5 lines changed: 0 ins; 5 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/utimes.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/src/vroot.cc

make: remove SCCS ident stuff
4 lines changed: 0 ins; 4 del; 0 mod; 340 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.