Code Review for tm_30_289ca5a

Prepared by:Richard Lowe (richlowe) on 2015-May-20 12:20 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 289ca5a830b1)
Compare against: HEAD^ (at a78a4d9e517b)
Summary of changes: 829 lines changed: 54 ins; 224 del; 551 mod; 25015 unchg
Patch of changes: tm_30_289ca5a.patch
Printable review: tm_30_289ca5a.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master 

make: translate using gettext, rather than the unmaintainable catgets
4 lines changed: 4 ins; 0 del; 0 mod; 1167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
1 line changed: 1 ins; 0 del; 0 mod; 837 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
4 lines changed: 1 ins; 0 del; 3 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/Makefile.com 

make: translate using gettext, rather than the unmaintainable catgets
5 lines changed: 5 ins; 0 del; 0 mod; 18 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
3 lines changed: 2 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/ar.cc 

make: translate using gettext, rather than the unmaintainable catgets
17 lines changed: 1 ins; 0 del; 16 mod; 829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/depvar.cc 

make: translate using gettext, rather than the unmaintainable catgets
4 lines changed: 2 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/doname.cc 

make: translate using gettext, rather than the unmaintainable catgets
41 lines changed: 0 ins; 5 del; 36 mod; 3167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/files.cc 

make: translate using gettext, rather than the unmaintainable catgets
9 lines changed: 1 ins; 0 del; 8 mod; 702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/globals.cc 

make: translate using gettext, rather than the unmaintainable catgets
3 lines changed: 0 ins; 1 del; 2 mod; 179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/implicit.cc 

make: translate using gettext, rather than the unmaintainable catgets
23 lines changed: 1 ins; 0 del; 22 mod; 1441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/main.cc 

make: translate using gettext, rather than the unmaintainable catgets
201 lines changed: 0 ins; 24 del; 177 mod; 3037 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/misc.cc 

make: translate using gettext, rather than the unmaintainable catgets
58 lines changed: 1 ins; 0 del; 57 mod; 686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/parallel.cc 

make: translate using gettext, rather than the unmaintainable catgets
35 lines changed: 1 ins; 0 del; 34 mod; 1871 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/pmake.cc 

make: translate using gettext, rather than the unmaintainable catgets
14 lines changed: 1 ins; 0 del; 13 mod; 406 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/read.cc 

make: translate using gettext, rather than the unmaintainable catgets
39 lines changed: 1 ins; 0 del; 38 mod; 2108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/read2.cc 

make: translate using gettext, rather than the unmaintainable catgets
30 lines changed: 1 ins; 0 del; 29 mod; 1866 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/rep.cc 

make: translate using gettext, rather than the unmaintainable catgets
1 line changed: 0 ins; 0 del; 1 mod; 393 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/bin/state.cc 

make: translate using gettext, rather than the unmaintainable catgets
14 lines changed: 0 ins; 0 del; 14 mod; 430 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/include/avo/intl.h (deleted) 

make: translate using gettext, rather than the unmaintainable catgets
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mk/defs.h 

make: translate using gettext, rather than the unmaintainable catgets
1 line changed: 0 ins; 1 del; 0 mod; 396 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/include/mksdmsi18n/mksdmsi18n.h (deleted) 

make: translate using gettext, rather than the unmaintainable catgets
38 lines changed: 0 ins; 38 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/mksh/defs.h 

make: translate using gettext, rather than the unmaintainable catgets
3 lines changed: 0 ins; 3 del; 0 mod; 947 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/include/vroot/vroot.h 

make: translate using gettext, rather than the unmaintainable catgets
2 lines changed: 0 ins; 2 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
3 lines changed: 1 ins; 1 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/bsd/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
2 lines changed: 2 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/makestate/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
2 lines changed: 2 ins; 0 del; 0 mod; 31 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/lib/mksdmsi18n/Makefile (deleted) 

make: translate using gettext, rather than the unmaintainable catgets
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/make/lib/mksdmsi18n/libmksdmsi18n_init.cc (deleted) 

make: translate using gettext, rather than the unmaintainable catgets
57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
10 lines changed: 10 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/dosys.cc 

make: translate using gettext, rather than the unmaintainable catgets
32 lines changed: 1 ins; 1 del; 30 mod; 547 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/macro.cc 

make: translate using gettext, rather than the unmaintainable catgets
31 lines changed: 1 ins; 1 del; 29 mod; 1306 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/misc.cc 

make: translate using gettext, rather than the unmaintainable catgets
15 lines changed: 1 ins; 1 del; 13 mod; 1099 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/mksh.cc 

make: translate using gettext, rather than the unmaintainable catgets
6 lines changed: 0 ins; 1 del; 5 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/mksh/read.cc 

make: translate using gettext, rather than the unmaintainable catgets
5 lines changed: 1 ins; 1 del; 3 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/Makefile 

make: translate using gettext, rather than the unmaintainable catgets
10 lines changed: 10 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/lock.cc 

make: translate using gettext, rather than the unmaintainable catgets
10 lines changed: 1 ins; 2 del; 7 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/report.cc 

make: translate using gettext, rather than the unmaintainable catgets
11 lines changed: 1 ins; 2 del; 8 mod; 324 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/make/lib/vroot/vroot.cc 

make: translate using gettext, rather than the unmaintainable catgets
4 lines changed: 0 ins; 2 del; 2 mod; 336 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.