smatch: check libld_* allocation functions

          --- old/usr/src/tools/smatch/src/check_freeing_null.c
          +++ new/usr/src/tools/smatch/src/check_freeing_null.c

   1    1  /*
   2    2   * Copyright (C) 2010 Dan Carpenter.
   3    3   *
   4    4   * This program is free software; you can redistribute it and/or
   5    5   * modify it under the terms of the GNU General Public License
   6    6   * as published by the Free Software Foundation; either version 2
   7    7   * of the License, or (at your option) any later version.
   8    8   *
   9    9   * This program is distributed in the hope that it will be useful,
  10   10   * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11   11   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12   12   * GNU General Public License for more details.
  13   13   *
  14   14   * You should have received a copy of the GNU General Public License
  15   15   * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
  16   16   */
  17   17  
  18   18  #include "smatch.h"
  19   19  
  20   20  static int my_id;
  21   21  
  22   22  static void match_free(const char *fn, struct expression *expr, void *data)
  23   23  {
  24   24          struct expression *arg_expr;
  25   25          char *name;
  26   26          sval_t sval;
  27   27  
  28   28          arg_expr = get_argument_from_call_expr(expr->args, 0);
  29   29          if (!get_implied_value(arg_expr, &sval))
  30   30                  return;
  31   31          if (sval.value != 0)
  32   32                  return;

  33   33          name = expr_to_var(arg_expr);
  34   34          sm_warning("calling %s() when '%s' is always NULL.", fn, name);
  35   35          free_string(name);
  36   36  }
  37   37  
  38   38  void check_freeing_null(int id)
  39   39  {
  40   40          my_id = id;
  41   41          if (!option_spammy)
  42   42                  return;
  43      -        if (option_project == PROJ_KERNEL)
       43 +        if (option_project == PROJ_KERNEL) {
  44   44                  add_function_hook("kfree", &match_free, NULL);
  45      -        else
       45 +        } else {
  46   46                  add_function_hook("free", &match_free, NULL);
       47 +        }
       48 +
       49 +        if (option_project == PROJ_ILLUMOS_USER)
       50 +                add_function_hook("libld_free", &match_free, NULL);
  47   51  }
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX