Prepared by: | Richard Lowe (richlowe) on 2014-Feb-13 22:45 -0500 EST |
---|---|
Workspace: | /builds/work/illumos/illumos-git (at 628c19cbb252) |
Compare against: | omniti/master (git://github.com/omniti-labs/illumos-omnios at 19b4ae69afd4) |
Summary of changes: | 214 lines changed: 122 ins; 64 del; 28 mod; 13504 unchg |
Patch of changes: | omnios_quiet.patch |
Printable review: | omnios_quiet.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/check_rtime
Add exceptions for objects in which the omnios build system includes bad runpaths2 lines changed: 2 ins; 0 del; 0 mod; 229 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/bootadm/Makefile
don't pass in lint libraries which no longer exist gag lint errors that stem from lint libraries that the omnios build system does not build5 lines changed: 4 ins; 0 del; 1 mod; 71 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/fiocompress/Makefile
gag lint errors that stem from lint libraries that the omnios build system does not build3 lines changed: 1 ins; 2 del; 0 mod; 62 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/tpmadm/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 60 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/p12split/Makefile
don't pass in lint libraries which no longer exist gag lint errors that stem from lint libraries that the omnios build system does not build6 lines changed: 5 ins; 0 del; 1 mod; 38 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/p12split/p12split.c
remove lint supression made unnecessary by the openssl upgrade8 lines changed: 0 ins; 7 del; 1 mod; 649 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/wanboot-cgi/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 38 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wanboot/wanboot-cgi/wanboot-cgi.c
remove lint supression made unnecessary by the openssl upgrade2 lines changed: 0 ins; 2 del; 0 mod; 1901 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/fabric-xlate/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 42 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/isns/isnsadm/Makefile
don't pass in lint libraries which no longer exist gag lint errors that stem from lint libraries that the omnios build system does not build5 lines changed: 4 ins; 0 del; 1 mod; 61 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/isns/isnsd/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 104 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/unix/unix.c
LINTED a bad cast align warning that seems to be oddly omnios specific. I think the alignment of any pointer we receive from mdb_zalloc must be sufficiently aligned for 'long' on both x86 platforms.1 line changed: 1 ins; 0 del; 0 mod; 934 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/smbsrv/smbd/smbd_spool.c
Correctly merge "2991 Allow building without SMB printing support"53 lines changed: 44 ins; 8 del; 1 mod; 515 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/libssh/Makefile.com
don't pass in lint libraries which no longer exist1 line changed: 0 ins; 0 del; 1 mod; 115 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/sftp-server/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 55 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/sftp/Makefile
don't pass in lint libraries which no longer exist3 lines changed: 2 ins; 0 del; 1 mod; 59 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/ssh-add/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 56 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/ssh-agent/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 56 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/ssh-keygen/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 56 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/ssh-keyscan/Makefile
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 56 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/ssh/Makefile
don't pass in lint libraries which no longer exist6 lines changed: 4 ins; 2 del; 0 mod; 66 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libkmf/plugins/kmf_openssl/Makefile.com
don't pass in lint libraries which no longer exist2 lines changed: 0 ins; 0 del; 2 mod; 74 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libkmf/plugins/kmf_openssl/common/openssl_spi.c
(void) an sk_set via a macro which upsets lint. If the macro is complicated, this might need to be /* LINTED */ instead remove lint supression made unnecessary by the openssl upgrade17 lines changed: 0 ins; 14 del; 3 mod; 5580 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpkg/Makefile.com
don't pass in lint libraries which no longer exist5 lines changed: 4 ins; 0 del; 1 mod; 90 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/Makefile.com
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 60 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/autofs/Makefile.com
don't pass in lint libraries which no longer exist5 lines changed: 3 ins; 0 del; 2 mod; 72 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/nfs/Makefile.com
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 67 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshare/smbfs/Makefile.com
don't pass in lint libraries which no longer exist4 lines changed: 3 ins; 0 del; 1 mod; 62 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libwanboot/Makefile.com
don't pass in lint libraries which no longer exist6 lines changed: 5 ins; 0 del; 1 mod; 98 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_tpm/Makefile.com
don't pass in lint libraries which no longer exist5 lines changed: 5 ins; 0 del; 0 mod; 103 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/Makefile
remove machid manual pages, since machid was removed15 lines changed: 0 ins; 15 del; 0 mod; 723 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.man1.inc
remove machid manual pages, since machid was removed14 lines changed: 0 ins; 14 del; 0 mod; 311 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/grow.c
os/grow: define 'p' under the same ifdef as it's consumed2 lines changed: 2 ins; 0 del; 0 mod; 1041 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.