Code Review for il_9884

Prepared by:Richard Lowe on 2018-Oct-11 01:49 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at 6fc70a570f3e)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 526759101614)
Summary of changes: 133 lines changed: 9 ins; 50 del; 74 mod; 7862 unchg
Patch of changes: il_9884.patch
Printable review: il_9884.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

9884 cw(1) should use -fpic rather than -Kpic
15 lines changed: 1 ins; 0 del; 14 mod; 1171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 186 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 0 del; 3 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/c_synonyms/amd64/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/c_synonyms/i386/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 2 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/c_synonyms/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 2 del; 1 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/c_synonyms/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/efcode/engine/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 2 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/libmdesc/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/gss_mechs/mech_krb5/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libast/amd64/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libast/i386/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libast/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libast/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbc/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
12 lines changed: 0 ins; 0 del; 12 mod; 455 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4u-opl/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4u-us3-hwcap1/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4u-us3-hwcap2/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4u/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4v-hwcap1/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/capabilities/sun4v-hwcap2/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 1430 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 1341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace_jni/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libndmp/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
3 lines changed: 0 ins; 0 del; 3 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnsl/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
4 lines changed: 0 ins; 3 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libresolv2/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
4 lines changed: 0 ins; 2 del; 2 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtnfprobe/Makefile.com

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 1 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs_core/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/sparc/Makefile

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 1 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libmlsvc/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
4 lines changed: 0 ins; 3 del; 1 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmbrp/sparcv9/Makefile

9884 cw(1) should use -fpic rather than -Kpic
2 lines changed: 0 ins; 1 del; 1 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

9884 cw(1) should use -fpic rather than -Kpic
39 lines changed: 8 ins; 29 del; 2 mod; 1705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/ucbcmd/sbcp/Makefile

9884 cw(1) should use -fpic rather than -Kpic
1 line changed: 0 ins; 0 del; 1 mod; 68 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.