Code Review for il_9001

Prepared by:Richard Lowe (richlowe) on 2018-Feb-02 23:18 +0000 UTC
Workspace:/builds/work/illumos/illumos-git (at 1111e4e80fae)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 16b8cff56143)
Summary of changes: 4571 lines changed: 0 ins; 4556 del; 15 mod; 4838 unchg
Patch of changes: il_9001.patch
Printable review: il_9001.pdf

------ ------ ------ ------ ------ Old --- Patch --- .hgignore (deleted) 

9005 remove .hgignore
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-build-onbld.mf 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
19 lines changed: 0 ins; 19 del; 0 mod; 248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/Makefile 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
1 line changed: 0 ins; 1 del; 0 mod; 158 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/README.tools 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
18 lines changed: 0 ins; 17 del; 1 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/onbld/Makefile 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
1 line changed: 0 ins; 1 del; 0 mod; 60 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/Scm/Backup.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
980 lines changed: 0 ins; 980 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/onbld/Scm/Makefile 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
4 lines changed: 0 ins; 3 del; 1 mod; 45 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/Scm/Version.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
122 lines changed: 0 ins; 122 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/Scm/WorkSpace.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
1076 lines changed: 0 ins; 1076 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/hgext/Makefile (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
58 lines changed: 0 ins; 58 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/hgext/__init__.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/onbld/hgext/cdm.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
1530 lines changed: 0 ins; 1530 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/Makefile 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
4 lines changed: 0 ins; 4 del; 0 mod; 174 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/scripts/hg-active.py (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
130 lines changed: 0 ins; 130 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/scripts/hgsetup.1onbld (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/scripts/hgsetup.sh (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
189 lines changed: 0 ins; 189 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/scripts/hgstyle (deleted) 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/webrev.1onbld
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
9 lines changed: 0 ins; 8 del; 1 mod; 449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/webrev.sh 

9001 cdm is useless, remove it
9002 webrev should know how to get the git user name
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
282 lines changed: 0 ins; 270 del; 12 mod; 3444 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.