Code Review for il_8609

Prepared by: (richlowe) on 2017-Sep-04 19:56 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at ab09082acfa9)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at ce1d04bfb432)
Summary of changes: 1857 lines changed: 519 ins; 1267 del; 71 mod; 10293 unchg
Patch of changes: il_8609.patch
Printable review: il_8609.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/awk_xpg4/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/awk_xpg4/inc.flg (deleted)

8609 want a position independent CRT
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cron/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 227 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/cron/inc.flg (deleted)

8609 want a position independent CRT
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/date/Makefile

8609 want a position independent CRT
4 lines changed: 0 ins; 2 del; 2 mod; 56 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/date/inc.flg (deleted)

8609 want a position independent CRT
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ed/Makefile

8609 want a position independent CRT
4 lines changed: 0 ins; 0 del; 4 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ed/inc.flg

8609 want a position independent CRT
3 lines changed: 0 ins; 3 del; 0 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/env/Makefile

8609 want a position independent CRT
4 lines changed: 0 ins; 2 del; 2 mod; 51 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/env/inc.flg (deleted)

8609 want a position independent CRT
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/getconf/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 121 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/getconf/inc.flg (deleted)

8609 want a position independent CRT
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/link/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 59 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/link/inc.flg (deleted)

8609 want a position independent CRT
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mv/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/mv/inc.flg (deleted)

8609 want a position independent CRT
31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/nice/Makefile

8609 want a position independent CRT
4 lines changed: 0 ins; 2 del; 2 mod; 52 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/nice/inc.flg (deleted)

8609 want a position independent CRT
30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/0@0/amd64/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/0@0/i386/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 1 del; 1 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/0@0/sparc/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 1 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/0@0/sparcv9/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 1 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/amd64/Makefile

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/i386/Makefile

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/sparc/Makefile

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/sparcv9/Makefile

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/vi/port/Makefile

8609 want a position independent CRT
4 lines changed: 0 ins; 0 del; 4 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/vi/port/inc.flg

8609 want a position independent CRT
5 lines changed: 0 ins; 4 del; 1 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 0 del; 3 mod; 722 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/amd64/crt1.s (deleted)

8609 want a position independent CRT
192 lines changed: 0 ins; 192 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/amd64/gcrt1.s (deleted)

8609 want a position independent CRT
191 lines changed: 0 ins; 191 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/i386/crt1.s (deleted)

8609 want a position independent CRT
216 lines changed: 0 ins; 216 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/i386/gcrt1.s (deleted)

8609 want a position independent CRT
206 lines changed: 0 ins; 206 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/sparc/crti.s (deleted)

8609 want a position independent CRT
60 lines changed: 0 ins; 60 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/common/sparc/crtn.s (deleted)

8609 want a position independent CRT
54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/Makefile (renamed and modified from usr/src/lib/common/Makefile)

8609 want a position independent CRT
7 lines changed: 1 ins; 4 del; 2 mod; 42 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/crt/Makefile.com

8609 want a position independent CRT
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/amd64/Makefile (renamed and modified from usr/src/lib/common/amd64/Makefile)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 30 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/crt/amd64/crti.s (renamed from usr/src/lib/common/amd64/crti.s)

8609 want a position independent CRT
0 lines changed: 0 ins; 0 del; 0 mod; 58 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/crt/amd64/crtn.s (renamed from usr/src/lib/common/amd64/crtn.s)

8609 want a position independent CRT
0 lines changed: 0 ins; 0 del; 0 mod; 50 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/crt/amd64/mach-crt1.s

8609 want a position independent CRT
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/crt/common/common-crt.c

8609 want a position independent CRT
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-Xa.c (renamed and modified from usr/src/lib/common/common/values-Xa.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-Xc.c (renamed and modified from usr/src/lib/common/common/values-Xc.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-Xs.c (renamed and modified from usr/src/lib/common/common/values-Xs.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-Xt.c (renamed and modified from usr/src/lib/common/common/values-Xt.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-xpg4.c (renamed and modified from usr/src/lib/common/common/values-xpg4.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/common/values-xpg6.c (renamed and modified from usr/src/lib/common/common/values-xpg6.c)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/i86/Makefile (renamed and modified from usr/src/lib/common/sparc/Makefile)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/i86/crti.s (renamed and modified from usr/src/lib/common/i386/crti.s)

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/i86/crtn.s (renamed and modified from usr/src/lib/common/i386/crtn.s)

8609 want a position independent CRT
1 line changed: 0 ins; 1 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/i86/fsr.s (renamed and modified from usr/src/lib/common/i386/fsr.s)

8609 want a position independent CRT
27 lines changed: 8 ins; 13 del; 6 mod; 140 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/crt/i86/mach-crt1.s

8609 want a position independent CRT
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/crt/sparc/crti.s (renamed from usr/src/lib/common/sparcv9/crti.s)

8609 want a position independent CRT
0 lines changed: 0 ins; 0 del; 0 mod; 59 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/crt/sparc/crtn.s (renamed from usr/src/lib/common/sparcv9/crtn.s)

8609 want a position independent CRT
0 lines changed: 0 ins; 0 del; 0 mod; 52 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/crt/sparc/mach-crt1.s

8609 want a position independent CRT
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/sparcv7/Makefile (renamed and modified from usr/src/lib/common/i386/Makefile)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 29 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/crt/sparcv9/Makefile (renamed and modified from usr/src/lib/common/sparcv9/Makefile)

8609 want a position independent CRT
2 lines changed: 0 ins; 2 del; 0 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/Makefile.targ

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 1266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 1346 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/gen/makectxt.c

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/threads/machdep.c

8609 want a position independent CRT
7 lines changed: 0 ins; 0 del; 7 mod; 257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/req.flg

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 30 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 1417 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

8609 want a position independent CRT
2 lines changed: 0 ins; 0 del; 2 mod; 1329 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc_db/amd64/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc_db/i386/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc_db/sparc/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc_db/sparcv9/Makefile

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnsl/Makefile.com

8609 want a position independent CRT
1 line changed: 0 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/req.flg

8609 want a position independent CRT
3 lines changed: 0 ins; 2 del; 1 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-library-lint.mf

8609 want a position independent CRT
42 lines changed: 2 ins; 39 del; 1 mod; 547 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-library-c-runtime.mf

8609 want a position independent CRT
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.