Code Review for il_8571

Prepared by:Richard Lowe (richlowe) on 2018-Jan-25 19:54 +0000 UTC
Workspace:/builds/work/illumos/illumos-git (at 3e8e54704605)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at a48ca82f1984)
Summary of changes: 3644 lines changed: 8 ins; 3634 del; 2 mod; 2150 unchg
Patch of changes: il_8571.patch
Printable review: il_8571.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

8571 Makefile.master should not trust $PATH
9 lines changed: 8 ins; 1 del; 0 mod; 1175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-build-onbld.mf

8998 depcheck is useless and should be removed
8992 checkproto is useless and can be deleted
8991 pmodes is useless and can be deleted
8990 /opt/onbld/gk is useless
12 lines changed: 0 ins; 12 del; 0 mod; 267 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/Makefile

8998 depcheck is useless and should be removed
8991 pmodes is useless and can be deleted
8990 /opt/onbld/gk is useless
4 lines changed: 0 ins; 4 del; 0 mod; 159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/Makefile.tools

8990 /opt/onbld/gk is useless
9 lines changed: 0 ins; 9 del; 0 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/README.tools

8998 depcheck is useless and should be removed
8992 checkproto is useless and can be deleted
8991 pmodes is useless and can be deleted
8990 /opt/onbld/gk is useless
29 lines changed: 0 ins; 27 del; 2 mod; 276 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/DependencyCheck.txt (deleted)

8998 depcheck is useless and should be removed
129 lines changed: 0 ins; 129 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/Makefile (deleted)

8998 depcheck is useless and should be removed
54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/SampleLinks (deleted)

8998 depcheck is useless and should be removed
75 lines changed: 0 ins; 75 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/SamplePkgLinks (deleted)

8998 depcheck is useless and should be removed
34 lines changed: 0 ins; 34 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/examples.txt (deleted)

8998 depcheck is useless and should be removed
447 lines changed: 0 ins; 447 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/get_depend_info (deleted)

8998 depcheck is useless and should be removed
552 lines changed: 0 ins; 552 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/get_depend_info.1onbld (deleted)

8998 depcheck is useless and should be removed
200 lines changed: 0 ins; 200 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/make_pkg_db (deleted)

8998 depcheck is useless and should be removed
527 lines changed: 0 ins; 527 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/depcheck/make_pkg_db.1onbld (deleted)

8998 depcheck is useless and should be removed
196 lines changed: 0 ins; 196 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/gk/Makefile (deleted)

8990 /opt/onbld/gk is useless
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/gk/cshrc.sh (deleted)

8990 /opt/onbld/gk is useless
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/gk/gen_make.machines.sh (deleted)

8990 /opt/onbld/gk is useless
48 lines changed: 0 ins; 48 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/gk/login.sh (deleted)

8990 /opt/onbld/gk is useless
69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/pmodes/Makefile (deleted)

8991 pmodes is useless and can be deleted
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/pmodes/README.pmodes (deleted)

8991 pmodes is useless and can be deleted
119 lines changed: 0 ins; 119 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/pmodes/binsearch.c (deleted)

8991 pmodes is useless and can be deleted
159 lines changed: 0 ins; 159 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/pmodes/binsearch.h (deleted)

8991 pmodes is useless and can be deleted
37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/pmodes/pmodes.c (deleted)

8991 pmodes is useless and can be deleted
690 lines changed: 0 ins; 690 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/Makefile

8992 checkproto is useless and can be deleted
1 line changed: 0 ins; 1 del; 0 mod; 178 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/tools/scripts/checkproto.sh (deleted)

8992 checkproto is useless and can be deleted
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.