Code Review for il_8112

Prepared by:Richard Lowe (richlowe) on 2017-May-26 19:24 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 7ec2473e7cec)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at ade2ca5bfc7c)
Summary of changes: 17494 lines changed: 262 ins; 17198 del; 34 mod; 7679 unchg
Patch of changes: il_8112.patch
Printable review: il_8112.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

8277 EOF filesync
2 lines changed: 0 ins; 2 del; 0 mod; 839 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/Makefile 

8114 EOF rwho
2 lines changed: 0 ins; 0 del; 2 mod; 185 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/cmd-inet/usr.bin/ruptime.c (deleted) 

8114 EOF rwho
298 lines changed: 0 ins; 298 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/cmd-inet/usr.bin/rwho.c (deleted) 

8114 EOF rwho
192 lines changed: 0 ins; 192 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/Makefile 

8114 EOF rwho
3 lines changed: 0 ins; 0 del; 3 mod; 272 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/cmd-inet/usr.sbin/in.rwhod.c (deleted) 

8114 EOF rwho
777 lines changed: 0 ins; 777 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/mib/tst.udp.ksh 

8112 EOF crazier RPC daemons
6 lines changed: 0 ins; 1 del; 5 mod; 68 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/Makefile (deleted) 

8277 EOF filesync
73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/README (deleted) 

8277 EOF filesync
453 lines changed: 0 ins; 453 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/acls.c (deleted) 

8277 EOF filesync
293 lines changed: 0 ins; 293 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/action.c (deleted) 

8277 EOF filesync
1259 lines changed: 0 ins; 1259 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/anal.c (deleted) 

8277 EOF filesync
1114 lines changed: 0 ins; 1114 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/base.c (deleted) 

8277 EOF filesync
912 lines changed: 0 ins; 912 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/database.h (deleted) 

8277 EOF filesync
307 lines changed: 0 ins; 307 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/debug.c (deleted) 

8277 EOF filesync
359 lines changed: 0 ins; 359 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/debug.h (deleted) 

8277 EOF filesync
66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/eval.c (deleted) 

8277 EOF filesync
997 lines changed: 0 ins; 997 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/files.c (deleted) 

8277 EOF filesync
591 lines changed: 0 ins; 591 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/filesync.h (deleted) 

8277 EOF filesync
164 lines changed: 0 ins; 164 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/ignore.c (deleted) 

8277 EOF filesync
364 lines changed: 0 ins; 364 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/main.c (deleted) 

8277 EOF filesync
687 lines changed: 0 ins; 687 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/messages.h (deleted) 

8277 EOF filesync
225 lines changed: 0 ins; 225 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/recon.c (deleted) 

8277 EOF filesync
833 lines changed: 0 ins; 833 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/rename.c (deleted) 

8277 EOF filesync
261 lines changed: 0 ins; 261 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/filesync/rules.c (deleted) 

8277 EOF filesync
638 lines changed: 0 ins; 638 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rpcsvc/Makefile 

8112 EOF crazier RPC daemons
162 lines changed: 0 ins; 158 del; 4 mod; 78 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rpc.rusersd.c (deleted) 

8112 EOF crazier RPC daemons
484 lines changed: 0 ins; 484 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rstat.xml (deleted) 

8112 EOF crazier RPC daemons
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rstat_main.c (deleted) 

8112 EOF crazier RPC daemons
181 lines changed: 0 ins; 181 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rstat_proc.c (deleted) 

8112 EOF crazier RPC daemons
1100 lines changed: 0 ins; 1100 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rstat_v2.x (deleted) 

8112 EOF crazier RPC daemons
86 lines changed: 0 ins; 86 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rup.c (deleted) 

8112 EOF crazier RPC daemons
541 lines changed: 0 ins; 541 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rusers.c (deleted) 

8112 EOF crazier RPC daemons
652 lines changed: 0 ins; 652 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rusers.xml (deleted) 

8112 EOF crazier RPC daemons
129 lines changed: 0 ins; 129 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rwall.c (deleted) 

8112 EOF crazier RPC daemons
266 lines changed: 0 ins; 266 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/rwall_subr.c (deleted) 

8112 EOF crazier RPC daemons
119 lines changed: 0 ins; 119 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/spray.c (deleted) 

8112 EOF crazier RPC daemons
184 lines changed: 0 ins; 184 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/spray.xml (deleted) 

8112 EOF crazier RPC daemons
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/spray_subr.c (deleted) 

8112 EOF crazier RPC daemons
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/rpcsvc/wall.xml (deleted) 

8112 EOF crazier RPC daemons
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/profile/generic_limited_net.xml 

8112 EOF crazier RPC daemons
32 lines changed: 0 ins; 31 del; 1 mod; 310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/profile/inetd_generic.xml 

8112 EOF crazier RPC daemons
18 lines changed: 0 ins; 18 del; 0 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/Makefile 

8114 EOF rwho
1 line changed: 0 ins; 0 del; 1 mod; 437 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/head/protocols/rwhod.h (deleted) 

8114 EOF rwho
76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/Makefile 

8277 EOF filesync
8114 EOF rwho
8112 EOF crazier RPC daemons
5 lines changed: 0 ins; 5 del; 0 mod; 718 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/filesync.1 (deleted) 

8277 EOF filesync
597 lines changed: 0 ins; 597 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/rup.1 (deleted) 

8112 EOF crazier RPC daemons
79 lines changed: 0 ins; 79 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/ruptime.1 (deleted) 

8114 EOF rwho
104 lines changed: 0 ins; 104 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/rusers.1 (deleted) 

8112 EOF crazier RPC daemons
97 lines changed: 0 ins; 97 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/rwho.1 (deleted) 

8114 EOF rwho
64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1c/Makefile 

8112 EOF crazier RPC daemons
1 line changed: 0 ins; 1 del; 0 mod; 46 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1c/rup.1c (deleted) 

8112 EOF crazier RPC daemons
72 lines changed: 0 ins; 72 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/Makefile 

8114 EOF rwho
8112 EOF crazier RPC daemons
16 lines changed: 0 ins; 16 del; 0 mod; 737 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/in.rwhod.1m (deleted) 

8114 EOF rwho
133 lines changed: 0 ins; 133 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/rpc.rstatd.1m (deleted) 

8112 EOF crazier RPC daemons
49 lines changed: 0 ins; 49 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/rpc.rusersd.1m (deleted) 

8112 EOF crazier RPC daemons
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/rpc.rwalld.1m (deleted) 

8112 EOF crazier RPC daemons
48 lines changed: 0 ins; 48 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/rpc.sprayd.1m (deleted) 

8112 EOF crazier RPC daemons
54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/rwall.1m (deleted) 

8112 EOF crazier RPC daemons
73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/spray.1m (deleted) 

8112 EOF crazier RPC daemons
81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3rpc/Makefile 

8112 EOF crazier RPC daemons
2 lines changed: 1 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3rpc/rstat.3rpc
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

8112 EOF crazier RPC daemons
6 lines changed: 0 ins; 5 del; 1 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3rpc/spray.3rpc (renamed and modified from usr/src/man/man3socket/spray.3socket)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

8112 EOF crazier RPC daemons
8 lines changed: 1 ins; 4 del; 3 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3socket/Makefile 

8112 EOF crazier RPC daemons
2 lines changed: 0 ins; 1 del; 1 mod; 262 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/Makefile 

8277 EOF filesync
1 line changed: 0 ins; 1 del; 0 mod; 295 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man4/packingrules.4 (deleted) 

8277 EOF filesync
182 lines changed: 0 ins; 182 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.man4.inc 

8277 EOF filesync
1 line changed: 0 ins; 1 del; 0 mod; 117 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/compatibility-ucb.mf 

8114 EOF rwho
2 lines changed: 0 ins; 2 del; 0 mod; 229 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/diagnostic-snoop.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/network-finger.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/network-rdist.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/network-rsh.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/network-talk.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/network-whois.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-legacy.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
8 lines changed: 6 ins; 0 del; 2 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-network-clients.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
8277 EOF filesync
8114 EOF rwho
8112 EOF crazier RPC daemons
57 lines changed: 0 ins; 52 del; 5 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-network-servers.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
8114 EOF rwho
8112 EOF crazier RPC daemons
85 lines changed: 0 ins; 80 del; 5 mod; 29 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/service-network-rsh.mf 

8113 Split the old network clients/servers packages into more easily minimizable pieces
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-uucp.mf 

8112 EOF crazier RPC daemons
1 line changed: 0 ins; 1 del; 0 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf 

8114 EOF rwho
1 line changed: 0 ins; 1 del; 0 mod; 2119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3rpc.inc 

8112 EOF crazier RPC daemons
1 line changed: 1 ins; 0 del; 0 mod; 18 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3socket.inc 

8112 EOF crazier RPC daemons
1 line changed: 0 ins; 1 del; 0 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/ucbcmd/Makefile 

8114 EOF rwho
2 lines changed: 0 ins; 2 del; 0 mod; 178 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.