| Prepared by: | Richard Lowe (richlowe) on 2016-Jun-30 21:58 -0400 EDT |
|---|---|
| Workspace: | /builds/work/illumos/illumos-git (at 4f59a1eddd96) |
| Compare against: | 05ebdf6 (at 05ebdf600afd) |
| Summary of changes: | 66 lines changed: 32 ins; 17 del; 17 mod; 10836 unchg |
| Patch of changes: | il_7029-2-3.patch |
| Printable review: | il_7029-2-3.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_sparc.c
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)11 lines changed: 11 ins; 0 del; 0 mod; 409 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_sparcv9.c
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)14 lines changed: 11 ins; 2 del; 1 mod; 407 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zonecfg/zonecfg.c
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)32 lines changed: 4 ins; 14 del; 14 mod; 7601 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3proc/Makefile
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)1 line changed: 1 ins; 0 del; 0 mod; 422 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3proc.inc
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)1 line changed: 1 ins; 0 del; 0 mod; 236 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/secflags_zonecfg.sh
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)4 lines changed: 4 ins; 0 del; 0 mod; 174 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sysent.c
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)1 line changed: 0 ins; 0 del; 1 mod; 1206 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/vm/mach_vm_dep.c
Code review comments from pmooney (sundry), and igork (screwups in zonecfg refactoring)2 lines changed: 0 ins; 1 del; 1 mod; 381 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.