Print this page
Code review comments from jeffpc
   1 #! /usr/bin/ksh
   2 #
   3 #
   4 # This file and its contents are supplied under the terms of the
   5 # Common Development and Distribution License ("CDDL"), version 1.0.
   6 # You may only use this file in accordance with the terms of version
   7 # 1.0 of the CDDL.
   8 #
   9 # A full copy of the text of the CDDL should have accompanied this
  10 # source.  A copy of the CDDL is also available via the Internet at
  11 # http://www.illumos.org/license/CDDL.
  12 #
  13 
  14 # Copyright 2015, Richald Lowe.
  15 
  16 # Verify that zones can be configured with security-flags
  17 LC_ALL=C                        # Collation is important
  18 
  19 expect_success() {
  20     name=$1
  21 
  22     (echo "create -b";
  23      echo "set zonepath=/$name.$$";
  24      cat /dev/stdin;
  25      echo "verify";
  26      echo "commit";
  27      echo "exit") | zonecfg -z $name.$$ > out.$$ 2>&1
  28 
  29     r=$?
  30 
  31     zonecfg -z $name.$$ delete -F
  32 
  33     if (($r != 0)); then
  34         printf "%s: FAIL\n" $name


   1 #! /usr/bin/ksh
   2 #
   3 #
   4 # This file and its contents are supplied under the terms of the
   5 # Common Development and Distribution License ("CDDL"), version 1.0.
   6 # You may only use this file in accordance with the terms of version
   7 # 1.0 of the CDDL.
   8 #
   9 # A full copy of the text of the CDDL should have accompanied this
  10 # source.  A copy of the CDDL is also available via the Internet at
  11 # http://www.illumos.org/license/CDDL.
  12 #
  13 
  14 # Copyright 2015, Richard Lowe.
  15 
  16 # Verify that zones can be configured with security-flags
  17 LC_ALL=C                        # Collation is important
  18 
  19 expect_success() {
  20     name=$1
  21 
  22     (echo "create -b";
  23      echo "set zonepath=/$name.$$";
  24      cat /dev/stdin;
  25      echo "verify";
  26      echo "commit";
  27      echo "exit") | zonecfg -z $name.$$ > out.$$ 2>&1
  28 
  29     r=$?
  30 
  31     zonecfg -z $name.$$ delete -F
  32 
  33     if (($r != 0)); then
  34         printf "%s: FAIL\n" $name