Print this page
Code review comments from jeffpc

*** 48,58 **** self_add() { echo "Add (self)" /usr/bin/psecflags -s current,noexecstack $$ cat > expected <<EOF ! I: aslr, noexecstack EOF /usr/bin/psecflags $$ | grep I: > output diff -u expected output || exit 1 } --- 48,58 ---- self_add() { echo "Add (self)" /usr/bin/psecflags -s current,noexecstack $$ cat > expected <<EOF ! I: aslr,noexecstack EOF /usr/bin/psecflags $$ | grep I: > output diff -u expected output || exit 1 }
*** 108,119 **** /usr/bin/psecflags -s aslr $$ /usr/bin/psecflags -s current,noexecstack -e sleep 10000 & pid=$! cat > expected <<EOF ! E: aslr, noexecstack ! I: aslr, noexecstack EOF /usr/bin/psecflags $pid | grep '[IE]:' > output kill $pid /usr/bin/psecflags -s none $$ diff -u expected output || exit 1 --- 108,119 ---- /usr/bin/psecflags -s aslr $$ /usr/bin/psecflags -s current,noexecstack -e sleep 10000 & pid=$! cat > expected <<EOF ! E: aslr,noexecstack ! I: aslr,noexecstack EOF /usr/bin/psecflags $pid | grep '[IE]:' > output kill $pid /usr/bin/psecflags -s none $$ diff -u expected output || exit 1