Code review comments from jeffpc

          --- old/usr/src/test/os-tests/tests/secflags/Makefile
          +++ new/usr/src/test/os-tests/tests/secflags/Makefile

   1    1  #
   2    2  # This file and its contents are supplied under the terms of the
   3    3  # Common Development and Distribution License ("CDDL"), version 1.0.
   4    4  # You may only use this file in accordance with the terms of version
   5    5  # 1.0 of the CDDL.
   6    6  #
   7    7  # A full copy of the text of the CDDL should have accompanied this
   8    8  # source.  A copy of the CDDL is also available via the Internet at
   9    9  # http://www.illumos.org/license/CDDL.
  10   10  #
  11   11  
  12   12  # Copyright 2015, Richard Lowe.
  13   13  
  14   14  
  15   15  include $(SRC)/cmd/Makefile.cmd
  16   16  include $(SRC)/test/Makefile.com
  17   17  
  18   18  PROG =  secflags_aslr           \
  19   19          secflags_core           \
  20   20          secflags_dts            \
  21   21          secflags_elfdump        \
  22   22          secflags_forbidnullmap  \
  23   23          secflags_limits         \
  24   24          secflags_noexecstack    \
  25   25          secflags_proc           \
  26   26          secflags_psecflags      \
  27   27          secflags_syscall        \
  28   28          secflags_truss          \
  29   29          secflags_zonecfg
  30   30  
  31   31  PROG += addrs-32 addrs-64 stacky
  32   32  
  33   33  ROOTOPTPKG = $(ROOT)/opt/os-tests
  34   34  TESTDIR = $(ROOTOPTPKG)/tests/secflags
  35   35  
  36   36  CMDS = $(PROG:%=$(TESTDIR)/%)
  37   37  $(CMDS) := FILEMODE = 0555
  38   38  

  39   39  addrs-32: addrs.c
  40   40          $(LINK.c) addrs.c -o $@ $(LDLIBS)
  41   41          $(POST_PROCESS)
  42   42  
  43   43  addrs-64: addrs.c
  44   44          $(LINK64.c) addrs.c -o $@ $(LDLIBS)
  45   45          $(POST_PROCESS)
  46   46  
  47   47  stacky := MAPFILE.NES=                  # Will foil the test, clearly
  48   48  stacky: stacky.o
  49      -        $(LINK.c) -m32 stacky.o -o $@ $(LDLIBS)
       49 +        $(LINK.c) stacky.o -o $@ $(LDLIBS)
  50   50          $(POST_PROCESS)
  51   51  
  52   52  secflags_syscall: secflags_syscall.c
  53      -        $(LINK.c) -m32 secflags_syscall.c -o $@ $(LDLIBS)
       53 +        $(LINK.c) secflags_syscall.c -o $@ $(LDLIBS)
  54   54          $(POST_PROCESS)
  55   55  
  56   56  all: $(PROG)
  57   57  
  58   58  install: all $(CMDS)
  59   59  
  60   60  lint: 
  61   61  
  62   62  clobber: clean
  63   63          -$(RM) $(PROG)
  64   64  
  65   65  clean:
  66   66  
  67   67  $(CMDS): $(TESTDIR) $(PROG)
  68   68  
  69   69  $(TESTDIR):
  70   70          $(INS.dir)
  71   71  
  72   72  $(TESTDIR)/%: %
  73   73          $(INS.file)
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX