Print this page
Code review comments from jeffpc
*** 221,241 ****
}
for (fd = flagdescs; fd->name != NULL; fd++) {
if (secflag_isset(flags, fd->value)) {
if (buf[0] != '\0')
! (void) strlcat(buf, ", ", buflen);
(void) strlcat(buf, fd->name, buflen);
}
secflag_clear(&flags, fd->value);
}
if (flags != 0) { /* unknown flags */
! char hexbuf[11]; /* 0x%08x */
! (void) snprintf(hexbuf, sizeof (hexbuf), "0x%08x", flags);
if (buf[0] != '\0')
! (void) strlcat(buf, ", ", buflen);
(void) strlcat(buf, hexbuf, buflen);
}
}
--- 221,241 ----
}
for (fd = flagdescs; fd->name != NULL; fd++) {
if (secflag_isset(flags, fd->value)) {
if (buf[0] != '\0')
! (void) strlcat(buf, ",", buflen);
(void) strlcat(buf, fd->name, buflen);
}
secflag_clear(&flags, fd->value);
}
if (flags != 0) { /* unknown flags */
! char hexbuf[19]; /* 0x%16 PRIx64 */
! (void) snprintf(hexbuf, sizeof (hexbuf), "0x%16" PRIx64, flags);
if (buf[0] != '\0')
! (void) strlcat(buf, ",", buflen);
(void) strlcat(buf, hexbuf, buflen);
}
}