Print this page
Code review comments from jeffpc

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/sgs/elfdump/common/struct_layout_amd64.c
          +++ new/usr/src/cmd/sgs/elfdump/common/struct_layout_amd64.c
↓ open down ↓ 370 lines elided ↑ open up ↑
 371  371          { 32,   8,      0,      0 },            /* pr_ino */
 372  372          { 40,   8,      0,      0 },            /* pr_offset */
 373  373          { 48,   8,      0,      0 },            /* pr_size */
 374  374          { 56,   4,      0,      0 },            /* pr_fileflags */
 375  375          { 60,   4,      0,      0 },            /* pr_fdflags */
 376  376          { 64,   1,      1024,   0 },            /* pr_path[] */
 377  377  };
 378  378  
 379  379  
 380  380  static const sl_prsecflags_layout_t prsecflags_layout = {
 381      -        { 0,    20,     0,      0 },            /* sizeof (prsecflags_t) */
      381 +        { 0,    40,     0,      0 },            /* sizeof (prsecflags_t) */
 382  382          { 0,    4,      0,      0 },            /* pr_version */
 383      -        { 4,    4,      0,      0 },            /* pr_effective */
 384      -        { 8,    4,      0,      0 },            /* pr_inherit */
 385      -        { 12,   4,      0,      0 },            /* pr_lower */
 386      -        { 16,   4,      0,      0 },            /* pr_upper */
      383 +        { 8,    8,      0,      0 },            /* pr_effective */
      384 +        { 16,   8,      0,      0 },            /* pr_inherit */
      385 +        { 24,   8,      0,      0 },            /* pr_lower */
      386 +        { 32,   8,      0,      0 },            /* pr_upper */
 387  387  };
 388  388  
 389  389  
 390  390  
 391  391  
 392  392  static const sl_arch_layout_t layout_amd64 = {
 393  393          &auxv_layout,
 394  394          &fltset_layout,
 395  395          &lwpsinfo_layout,
 396  396          &lwpstatus_layout,
↓ open down ↓ 25 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX