| Prepared by: | Richard Lowe (richlowe) on 2016-Jun-15 19:32 -0400 EDT |
|---|---|
| Workspace: | /builds/work/illumos/illumos-git (at 05ebdf600afd) |
| Compare against: | dc1087b (at dc1087bcc137) |
| Summary of changes: | 77 lines changed: 12 ins; 3 del; 62 mod; 20356 unchg |
| Patch of changes: | il_7029-1-2.patch |
| Printable review: | il_7029-1-2.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/corenote.c
Code review comments from jeffpc9 lines changed: 1 ins; 0 del; 8 mod; 1904 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_amd64.c
Code review comments from jeffpc5 lines changed: 0 ins; 0 del; 5 mod; 416 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_i386.c
Code review comments from jeffpc5 lines changed: 0 ins; 0 del; 5 mod; 416 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/corenote.c
Code review comments from jeffpc4 lines changed: 1 ins; 1 del; 2 mod; 2636 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/secflags/secflags.c
Code review comments from jeffpc4 lines changed: 0 ins; 0 del; 4 mod; 237 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/inc/priv_private.h
Code review comments from jeffpc2 lines changed: 2 ins; 0 del; 0 mod; 120 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/sys/sbrk.c
Code review comments from jeffpc6 lines changed: 0 ins; 1 del; 5 mod; 194 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libscf/common/highlevel.c
Code review comments from jeffpc5 lines changed: 4 ins; 1 del; 0 mod; 439 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man1/ld.1
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 1875 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man1/psecflags.1
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc9 lines changed: 0 ins; 0 del; 9 mod; 289 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man1m/zonecfg.1m
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 1896 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man3lib/libproc.3lib
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 1213 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man3proc/Psecflags.3proc
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc4 lines changed: 0 ins; 0 del; 4 mod; 73 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man4/core.4
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 482 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man4/proc.4
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 2967 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man5/privileges.5
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 1361 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man5/security-flags.5
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 104 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
usr/src/man/man5/smf_method.5
man:
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
TXT
HTML
Raw
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 582 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/Makefile
Code review comments from jeffpc2 lines changed: 0 ins; 0 del; 2 mod; 71 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/secflags_aslr.sh
Code review comments from jeffpc3 lines changed: 1 ins; 0 del; 2 mod; 71 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/secflags_elfdump.sh
Code review comments from jeffpc2 lines changed: 0 ins; 0 del; 2 mod; 77 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/secflags_psecflags.sh
Code review comments from jeffpc3 lines changed: 0 ins; 0 del; 3 mod; 192 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/secflags/secflags_zonecfg.sh
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 173 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/exec/elf/elf_impl.h
Code review comments from jeffpc2 lines changed: 2 ins; 0 del; 0 mod; 129 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/fork.c
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 1466 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/procfs.h
Code review comments from jeffpc1 line changed: 1 ins; 0 del; 0 mod; 872 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/secflags.h
Code review comments from jeffpc1 line changed: 0 ins; 0 del; 1 mod; 101 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.