Code Review for il_6648

Prepared by:Richard Lowe (richlowe) on 2016-Feb-12 11:52 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at d85098233d71)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 0803e914d351)
Summary of changes: 210 lines changed: 14 ins; 16 del; 180 mod; 11772 unchg
Patch of changes: il_6648.patch
Printable review: il_6648.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/awk/Makefile

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/Makefile.targ

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/tools/Makefile.com

6648 illumos build should be explicit about C standards
2 lines changed: 0 ins; 1 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/tools/Makefile.targ

6648 illumos build should be explicit about C standards
7 lines changed: 0 ins; 2 del; 5 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/tools/common/sgsmsg.c

6645 sgsmsg relies on undefined behaviour of loop-scoped variables
2 lines changed: 1 ins; 1 del; 0 mod; 1236 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zic/Makefile

6648 illumos build should be explicit about C standards
8 lines changed: 0 ins; 6 del; 2 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/Makefile.solaris.defs

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/grub/grub-0.97/netboot/io.h

6648 illumos build should be explicit about C standards
12 lines changed: 6 ins; 1 del; 5 mod; 233 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 1245 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 1326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 1404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 1315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/Makefile.libm.com

6648 illumos build should be explicit about C standards
10 lines changed: 6 ins; 0 del; 4 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/amd64/src/libm_inlines.h

6648 illumos build should be explicit about C standards
13 lines changed: 0 ins; 0 del; 13 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/common/m9x/fenv_inlines.h

6648 illumos build should be explicit about C standards
68 lines changed: 0 ins; 0 del; 68 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/i386/src/libm_inlines.h

6648 illumos build should be explicit about C standards
35 lines changed: 0 ins; 0 del; 35 mod; 316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/sparc/src/libm_inlines.h

6648 illumos build should be explicit about C standards
12 lines changed: 0 ins; 0 del; 12 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/sparcv9/src/libm_inlines.h

6648 illumos build should be explicit about C standards
12 lines changed: 0 ins; 0 del; 12 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsqlite/Makefile.com

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/zfs-tests/tests/functional/checksum/Makefile.subdirs

6648 illumos build should be explicit about C standards
2 lines changed: 0 ins; 0 del; 2 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/audio/drv/audioemu10k/dsp/asm10k.c

6648 illumos build should be explicit about C standards
6 lines changed: 0 ins; 4 del; 2 mod; 1087 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.rules

6648 illumos build should be explicit about C standards
2 lines changed: 0 ins; 0 del; 2 mod; 471 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/genassym/Makefile

6648 illumos build should be explicit about C standards
2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/genassym.c

6648 illumos build should be explicit about C standards
3 lines changed: 0 ins; 0 del; 3 mod; 188 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/Makefile.rules

6648 illumos build should be explicit about C standards
2 lines changed: 1 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/genassym/Makefile

6648 illumos build should be explicit about C standards
3 lines changed: 0 ins; 1 del; 2 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/audioemu10k/Makefile

6648 illumos build should be explicit about C standards
1 line changed: 0 ins; 0 del; 1 mod; 107 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.